Skip to content

Commit d06f192

Browse files
mbani01mbani01
committed
chore: use unified identity builder method & fix null sourceId
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
1 parent 23d0ee7 commit d06f192

3 files changed

Lines changed: 22 additions & 139 deletions

File tree

‎services/apps/snowflake_connectors/src/integrations/tnc/certificates/transformer.ts‎

Lines changed: 7 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
import { TNC_GRID, TncActivityType } from '@crowd/integrations'
22
import { getServiceChildLogger } from '@crowd/logging'
3-
import {
4-
IActivityData,
5-
IMemberData,
6-
MemberAttributeName,
7-
MemberIdentityType,
8-
PlatformType,
9-
} from '@crowd/types'
3+
import { IActivityData, MemberAttributeName, PlatformType } from '@crowd/types'
104

115
import { TransformedActivity } from '../../../core/transformerBase'
126
import { TncTransformerBase } from '../tncTransformerBase'
@@ -24,47 +18,14 @@ export class TncCertificatesTransformer extends TncTransformerBase {
2418
const certificateId = (row.CERTIFICATE_ID as string)?.trim()
2519
const learnerName = (row.LEARNER_NAME as string | null)?.trim() || null
2620
const lfUsername = (row.LFID as string | null)?.trim() || null
27-
28-
const identities: IMemberData['identities'] = []
2921
const sourceId = (row.USER_ID as string | null) || undefined
3022

31-
if (lfUsername) {
32-
identities.push(
33-
{
34-
platform: PlatformType.TNC,
35-
value: email,
36-
type: MemberIdentityType.EMAIL,
37-
verified: true,
38-
verifiedBy: PlatformType.TNC,
39-
sourceId,
40-
},
41-
{
42-
platform: PlatformType.TNC,
43-
value: lfUsername,
44-
type: MemberIdentityType.USERNAME,
45-
verified: true,
46-
verifiedBy: PlatformType.TNC,
47-
sourceId,
48-
},
49-
{
50-
platform: PlatformType.LFID,
51-
value: lfUsername,
52-
type: MemberIdentityType.USERNAME,
53-
verified: true,
54-
verifiedBy: PlatformType.TNC,
55-
sourceId,
56-
},
57-
)
58-
} else {
59-
identities.push({
60-
platform: PlatformType.TNC,
61-
value: email,
62-
type: MemberIdentityType.USERNAME,
63-
verified: true,
64-
verifiedBy: PlatformType.TNC,
65-
sourceId,
66-
})
67-
}
23+
const identities = this.buildMemberIdentities({
24+
email,
25+
sourceId,
26+
platformUsername: null,
27+
lfUsername,
28+
})
6829

6930
const activity: IActivityData = {
7031
type: TncActivityType.ISSUED_CERTIFICATION,

‎services/apps/snowflake_connectors/src/integrations/tnc/courses/transformer.ts‎

Lines changed: 8 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
import { TNC_GRID, TncActivityType } from '@crowd/integrations'
22
import { getServiceChildLogger } from '@crowd/logging'
3-
import {
4-
IActivityData,
5-
IMemberData,
6-
MemberAttributeName,
7-
MemberIdentityType,
8-
PlatformType,
9-
} from '@crowd/types'
3+
import { IActivityData, MemberAttributeName, PlatformType } from '@crowd/types'
104

115
import { TransformedActivity } from '../../../core/transformerBase'
126
import { TncTransformerBase } from '../tncTransformerBase'
@@ -32,47 +26,14 @@ export class TncCoursesTransformer extends TncTransformerBase {
3226

3327
const learnerName = (row.LEARNER_NAME as string | null)?.trim() || null
3428
const lfUsername = (row.LFID as string | null)?.trim() || null
29+
const sourceId = (row.INTERNAL_TI_USER_ID as string | null) || undefined
3530

36-
const identities: IMemberData['identities'] = []
37-
const sourceId = undefined
38-
39-
if (lfUsername) {
40-
identities.push(
41-
{
42-
platform: PlatformType.TNC,
43-
value: email,
44-
type: MemberIdentityType.EMAIL,
45-
verified: true,
46-
verifiedBy: PlatformType.TNC,
47-
sourceId,
48-
},
49-
{
50-
platform: PlatformType.TNC,
51-
value: lfUsername,
52-
type: MemberIdentityType.USERNAME,
53-
verified: true,
54-
verifiedBy: PlatformType.TNC,
55-
sourceId,
56-
},
57-
{
58-
platform: PlatformType.LFID,
59-
value: lfUsername,
60-
type: MemberIdentityType.USERNAME,
61-
verified: true,
62-
verifiedBy: PlatformType.TNC,
63-
sourceId,
64-
},
65-
)
66-
} else {
67-
identities.push({
68-
platform: PlatformType.TNC,
69-
value: email,
70-
type: MemberIdentityType.USERNAME,
71-
verified: true,
72-
verifiedBy: PlatformType.TNC,
73-
sourceId,
74-
})
75-
}
31+
const identities = this.buildMemberIdentities({
32+
email,
33+
sourceId,
34+
platformUsername: null,
35+
lfUsername,
36+
})
7637

7738
const productType = (row.PRODUCT_TYPE as string | null)?.trim() || null
7839

‎services/apps/snowflake_connectors/src/integrations/tnc/enrollments/transformer.ts‎

Lines changed: 7 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
import { TNC_GRID, TncActivityType } from '@crowd/integrations'
22
import { getServiceChildLogger } from '@crowd/logging'
3-
import {
4-
IActivityData,
5-
IMemberData,
6-
MemberAttributeName,
7-
MemberIdentityType,
8-
PlatformType,
9-
} from '@crowd/types'
3+
import { IActivityData, MemberAttributeName, PlatformType } from '@crowd/types'
104

115
import { TransformedActivity } from '../../../core/transformerBase'
126
import { TncTransformerBase } from '../tncTransformerBase'
@@ -27,47 +21,14 @@ export class TncEnrollmentsTransformer extends TncTransformerBase {
2721
const enrollmentId = (row.ENROLLMENT_ID as string)?.trim()
2822
const learnerName = (row.LEARNER_NAME as string | null)?.trim() || null
2923
const lfUsername = (row.LFID as string | null)?.trim() || null
30-
31-
const identities: IMemberData['identities'] = []
3224
const sourceId = (row.USER_ID as string | null) || undefined
3325

34-
if (lfUsername) {
35-
identities.push(
36-
{
37-
platform: PlatformType.TNC,
38-
value: email,
39-
type: MemberIdentityType.EMAIL,
40-
verified: true,
41-
verifiedBy: PlatformType.TNC,
42-
sourceId,
43-
},
44-
{
45-
platform: PlatformType.TNC,
46-
value: lfUsername,
47-
type: MemberIdentityType.USERNAME,
48-
verified: true,
49-
verifiedBy: PlatformType.TNC,
50-
sourceId,
51-
},
52-
{
53-
platform: PlatformType.LFID,
54-
value: lfUsername,
55-
type: MemberIdentityType.USERNAME,
56-
verified: true,
57-
verifiedBy: PlatformType.TNC,
58-
sourceId,
59-
},
60-
)
61-
} else {
62-
identities.push({
63-
platform: PlatformType.TNC,
64-
value: email,
65-
type: MemberIdentityType.USERNAME,
66-
verified: true,
67-
verifiedBy: PlatformType.TNC,
68-
sourceId,
69-
})
70-
}
26+
const identities = this.buildMemberIdentities({
27+
email,
28+
sourceId,
29+
platformUsername: null,
30+
lfUsername,
31+
})
7132

7233
const productType = (row.PRODUCT_TYPE as string | null)?.trim() || null
7334
const instructionType = (row.INSTRUCTION_TYPE as string | null)?.trim() || null

0 commit comments

Comments
 (0)