fix: simplify pr for deployment

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>

Author: ulemons

backend/.env.dist.local

@@ -208,6 +208,4 @@ POM_FETCHER_NON_CRITICAL_CONCURRENCY=20
 POM_FETCHER_REFRESH_DAYS=1
 POM_FETCHER_GROUP_DELAY_MS=100
 POM_FETCHER_FORCE_FULL_EXTRACTION=true
-POM_FETCHER_MAVEN_BASE_URL=https://maven-central.storage-download.googleapis.com/maven2
-MAVEN_SYNC_SOURCE=both
-MAVEN_DELTA_API_URL=https://maven-fetcher-production.up.railway.app
+POM_FETCHER_MAVEN_BASE_URL=https://maven-central.storage-download.googleapis.com/maven2

services/apps/packages_worker/src/config.ts

@@ -46,44 +46,13 @@ export function getEnricherConfig() {
   }
 }
 
-// Which source drives the critical Maven sync:
-//   'maven' → poll packages_universe by staleness (current behaviour, default/fallback)
-//   'api'   → only enrich what our delta feed reports as changed
-//   'both'  → run both passes in the same Temporal tick
-export type MavenSyncSource = 'api' | 'maven' | 'both'
-
-function parseMavenSyncSource(raw: string | undefined): MavenSyncSource {
-  if (raw === 'api' || raw === 'both') return raw
-  // Anything else (unset, typo, legacy value) falls back to the current behaviour.
-  return 'maven'
-}
-
 export function getMavenConfig() {
-  const syncSource = parseMavenSyncSource(process.env.MAVEN_SYNC_SOURCE)
-  const deltaApiBaseUrl = (process.env.MAVEN_DELTA_API_URL ?? '').replace(/\/+$/, '')
-
-  if (syncSource !== 'maven' && !deltaApiBaseUrl) {
-    throw new Error(`MAVEN_SYNC_SOURCE='${syncSource}' requires MAVEN_DELTA_API_URL to be set`)
-  }
-
   return {
     batchSize: requireEnvInt('POM_FETCHER_BATCH_SIZE'),
     concurrency: requireEnvInt('POM_FETCHER_CONCURRENCY'),
     nonCriticalBatchSize: requireEnvInt('POM_FETCHER_NON_CRITICAL_BATCH_SIZE'),
     nonCriticalConcurrency: requireEnvInt('POM_FETCHER_NON_CRITICAL_CONCURRENCY'),
     refreshDays: requireEnvInt('POM_FETCHER_REFRESH_DAYS'),
     groupDelayMs: requireEnvInt('POM_FETCHER_GROUP_DELAY_MS'),
-    syncSource,
-    deltaApi: {
-      baseUrl: deltaApiBaseUrl,
-      token: process.env.MAVEN_DELTA_API_TOKEN || undefined,
-      pageSize: process.env.MAVEN_DELTA_API_PAGE_SIZE
-        ? parseInt(process.env.MAVEN_DELTA_API_PAGE_SIZE, 10)
-        : 100,
-      lookbackMinutes: process.env.MAVEN_DELTA_API_LOOKBACK_MINUTES
-        ? parseInt(process.env.MAVEN_DELTA_API_LOOKBACK_MINUTES, 10)
-        : 15,
-      includePrerelease: process.env.MAVEN_DELTA_API_INCLUDE_PRERELEASE === 'true',
-    },
   }
 }

services/apps/packages_worker/src/maven/README.md

@@ -247,25 +247,6 @@ so the worker throws on startup if any is missing. Suggested values shown.
 | `POM_FETCHER_REFRESH_DAYS`             | `1`         | Staleness window — re-sync a package once its `last_synced_at` is older than N days (applies to both phases) |
 | `POM_FETCHER_GROUP_DELAY_MS`           | `200`–`400` | Delay between concurrent groups in the critical phase (rate-limit mitigation)                                |
 
-### Sync source (Temporal critical path)
-
-These select **where the critical sync gets its work from**. They affect only the Temporal
-`processMavenCriticalBatch` activity — the standalone backfill loop is unaffected. All are
-optional; unset/invalid values fall back to the current universe-polling behaviour.
-
-| Env var                              | Default | Description                                                                                                                                              |
-| ------------------------------------ | ------- | -------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `MAVEN_SYNC_SOURCE`                  | `maven` | `maven` = poll `packages_universe` by staleness (current behaviour). `api` = enrich only what the delta feed reports. `both` = run both passes per tick. |
-| `MAVEN_DELTA_API_URL`                | —       | Base URL of our delta feed (e.g. the Railway deployment). **Required** when source is `api` or `both`.                                                   |
-| `MAVEN_DELTA_API_TOKEN`              | —       | Optional bearer token for the delta feed.                                                                                                                |
-| `MAVEN_DELTA_API_PAGE_SIZE`          | `100`   | Page size for `/api/changes` pagination.                                                                                                                 |
-| `MAVEN_DELTA_API_LOOKBACK_MINUTES`   | `15`    | Rolling window size: each tick fetches `[now-N, now)`. Overlaps the cron interval on purpose — re-processing is safe (idempotent upserts).               |
-| `MAVEN_DELTA_API_INCLUDE_PRERELEASE` | `false` | Forwarded as `includePrerelease` to the feed.                                                                                                            |
-
-The delta-API path always runs **full extraction** (the feed is an explicit "this changed"
-signal) and only enriches packages that are `is_critical` in `packages_universe`; non-critical
-purls in the feed are dropped.
-
 **Concurrency guidance:** Maven Central handles 10–15 concurrent requests per IP without throttling. Retry logic with exponential backoff handles 429/403s. Keep `POM_FETCHER_CONCURRENCY` ≤ 5 locally — repeated local runs heat the IP (see [Known Exceptions](#maven-central-403-rate-limiting)).
 
 ---

services/apps/packages_worker/src/maven/activities.ts

@@ -3,54 +3,18 @@ import { getServiceChildLogger } from '@crowd/logging'
 import { getMavenConfig } from '../config'
 import { getPackagesDb } from '../db'
 
-import { BatchResult, processApiChangesBatch, processBatch } from './runMavenEnrichmentLoop'
+import { BatchResult, processBatch } from './runMavenEnrichmentLoop'
 
 const log = getServiceChildLogger('maven-activity')
 
-function addBatchResult(into: BatchResult, from: BatchResult): void {
-  into.processed += from.processed
-  into.skipped += from.skipped
-  into.error += from.error
-  into.unchanged += from.unchanged
-  into.hopLimitReached += from.hopLimitReached
-}
-
 export async function processMavenCriticalBatch(): Promise<BatchResult> {
   const config = getMavenConfig()
   const qx = await getPackagesDb()
 
-  const total: BatchResult = {
-    processed: 0,
-    skipped: 0,
-    error: 0,
-    unchanged: 0,
-    hopLimitReached: 0,
-  }
-
-  // Delta-API pass: enrich what our feed reports as changed (forces full extraction).
-  if (config.syncSource === 'api' || config.syncSource === 'both') {
-    try {
-      const apiResult = await processApiChangesBatch(qx, config)
-      log.info({ ...apiResult }, 'Maven delta-API batch complete')
-      addBatchResult(total, apiResult)
-    } catch (err) {
-      // In 'both' mode the universe-polling pass is the reliable backbone, so a flaky
-      // delta feed must never block it — log and continue. In 'api' mode there is no
-      // fallback, so let the activity fail and have Temporal retry it.
-      if (config.syncSource === 'api') throw err
-      const message = err instanceof Error ? err.message : String(err)
-      log.warn({ error: message }, 'Delta-API pass failed — continuing with universe-polling pass')
-    }
-  }
-
-  // Universe-polling pass: current behaviour — skip POM extraction when version is unchanged.
-  if (config.syncSource === 'maven' || config.syncSource === 'both') {
-    const mavenResult = await processBatch(qx, config, true, false)
-    log.info({ ...mavenResult }, 'Maven critical batch complete')
-    addBatchResult(total, mavenResult)
-  }
-
-  return total
+  // Universe-polling pass: skip POM extraction when version is unchanged.
+  const result = await processBatch(qx, config, true, false)
+  log.info({ ...result }, 'Maven critical batch complete')
+  return result
 }
 
 export async function processMavenNonCriticalBatch(): Promise<BatchResult> {