Skip to content

Commit e1f6f08

Browse files
joanagmaiambani01
authored andcommitted
fix: projects dropdown and collection starred on edition (#3070)
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
1 parent 7c0ef09 commit e1f6f08

5 files changed

Lines changed: 14 additions & 4 deletions

File tree

frontend/src/modules/admin/modules/collections/components/lf-collection-add-dropdown.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div>
3-
<lf-dropdown placement="bottom-end" :z-index="2090" width="14rem">
3+
<lf-dropdown placement="bottom-end" :z-index="2300" width="14rem">
44
<template #trigger>
55
<lf-button type="secondary-ghost" icon-only>
66
<lf-icon name="ellipsis" :size="24" class="text-gray-900" />

frontend/src/modules/admin/modules/collections/components/lf-collection-add.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ const form = reactive<CollectionFormModel>({
186186
type: '',
187187
categoryId: null,
188188
projects: [],
189+
starred: false,
189190
});
190191
191192
const rules = {
@@ -245,7 +246,7 @@ const onSubmit = () => {
245246
id: project.id,
246247
starred: project?.starred || false,
247248
})),
248-
starred: false,
249+
starred: !!form.starred,
249250
categoryId: form.categoryId,
250251
slug: form.name.toLowerCase().replace(/ /g, '-'),
251252
};

frontend/src/modules/admin/modules/collections/models/collection.model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,5 @@ export interface CollectionFormModel {
2929
type: string | null;
3030
categoryId: string | null;
3131
projects: InsightsProjectModel[];
32+
starred: boolean;
3233
}

frontend/src/ui-kit/dropdown/Dropdown.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
<template>
2-
<lf-popover :placement="props.placement" :persistent="props.persistent" :is-dropdown="true">
2+
<lf-popover
3+
:placement="props.placement"
4+
:persistent="props.persistent"
5+
:is-dropdown="true"
6+
:z-index="props.zIndex"
7+
>
38
<template #trigger>
49
<slot name="trigger" />
510
</template>
611
<template #default="{ close }">
712
<div
813
v-click-outside="close"
914
class="c-dropdown"
10-
:style="{ 'min-width': props.width, zIndex: props.zIndex }"
15+
:style="{ 'min-width': props.width }"
1116
@click="close"
1217
>
1318
<slot />

frontend/src/ui-kit/popover/Popover.vue

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ const props = withDefaults(defineProps<{
3838
triggerEvent?: PopoverTrigger,
3939
persistent?: boolean;
4040
isDropdown?: boolean;
41+
zIndex?: number | string;
4142
}>(), {
4243
placement: 'bottom-start',
4344
disabled: false,
@@ -46,6 +47,7 @@ const props = withDefaults(defineProps<{
4647
triggerEvent: 'click',
4748
persistent: false,
4849
isDropdown: false,
50+
zIndex: 'auto',
4951
});
5052
5153
const emit = defineEmits<{(e: 'update:visibility', value: boolean): void }>();
@@ -110,6 +112,7 @@ const popoverStyle = computed(() => {
110112
'--lf-popover-content-width': `${popover.value.offsetWidth / 16}rem`,
111113
'--lf-popover-content-height': `${popover.value.offsetHeight / 16}rem`,
112114
'--lf-popover-spacing': `${props.spacing / 16}rem`,
115+
'z-index': props.zIndex,
113116
};
114117
});
115118

0 commit comments

Comments
 (0)