fix: cache already checked ids

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

services/libs/data-access-layer/src/activities/sql.ts

@@ -580,6 +580,10 @@ export async function createOrUpdateRelations(
   let index = 0
 
   const activityIds = new Set<string>()
+  const checkedMembers = new Map<string, string>() // id -> resolved id (may differ if looked up via identity)
+  const checkedOrganizations = new Set<string>()
+  const checkedSegments = new Set<string>()
+  const checkedConversations = new Set<string>()
   const valueList: string[] = []
   for (const data of relations) {
     if (data.username === undefined || data.username === null) {
@@ -597,132 +601,166 @@ export async function createOrUpdateRelations(
     if (!skipChecks) {
       // check objectMember exists
       if (data.objectMemberId !== undefined && data.objectMemberId !== null) {
-        let objectMember = await qe.select(
-          `
+        if (checkedMembers.has(data.objectMemberId)) {
+          data.objectMemberId = checkedMembers.get(data.objectMemberId)
+        } else {
+          let objectMember = await qe.select(
+            `
       SELECT id
       FROM members
       WHERE id = $(objectMemberId)
     `,
-          {
-            objectMemberId: data.objectMemberId,
-          },
-        )
+            {
+              objectMemberId: data.objectMemberId,
+            },
+          )
 
-        if (objectMember.length === 0) {
-          if (data.objectMemberUsername && data.platform) {
-            objectMember = await qe.select(
-              `
+          if (objectMember.length === 0) {
+            if (data.objectMemberUsername && data.platform) {
+              objectMember = await qe.select(
+                `
           SELECT "memberId"
           FROM "memberIdentities"
-          WHERE value = $(value) 
-            and platform = $(platform) 
+          WHERE value = $(value)
+            and platform = $(platform)
             and verified = true
             and "deletedAt" is null
           limit 1
         `,
-              {
-                value: data.objectMemberUsername,
-                platform: data.platform,
-              },
-            )
-
-            if (objectMember.length === 0) {
-              data.objectMemberId = null
+                {
+                  value: data.objectMemberUsername,
+                  platform: data.platform,
+                },
+              )
+
+              if (objectMember.length === 0) {
+                checkedMembers.set(data.objectMemberId, null)
+                data.objectMemberId = null
+              } else {
+                checkedMembers.set(data.objectMemberId, objectMember[0].memberId)
+                data.objectMemberId = objectMember[0].memberId
+              }
             } else {
-              data.objectMemberId = objectMember[0].memberId
+              checkedMembers.set(data.objectMemberId, null)
+              data.objectMemberId = null
             }
           } else {
-            data.objectMemberId = null
+            checkedMembers.set(data.objectMemberId, data.objectMemberId)
           }
         }
       }
 
       // check conversation exists
       if (data.conversationId !== undefined && data.conversationId !== null) {
-        const conversation = await qe.select(
-          `
+        if (!checkedConversations.has(data.conversationId)) {
+          const conversation = await qe.select(
+            `
       SELECT id
       FROM conversations
       WHERE id = $(conversationId)
     `,
-          {
-            conversationId: data.conversationId,
-          },
-        )
+            {
+              conversationId: data.conversationId,
+            },
+          )
 
-        if (conversation.length === 0) {
-          data.conversationId = null
+          if (conversation.length === 0) {
+            data.conversationId = null
+          } else {
+            checkedConversations.add(data.conversationId)
+          }
         }
       }
 
       // check segmentId exists
-      const segment = await qe.select(
-        `
+      if (!checkedSegments.has(data.segmentId)) {
+        const segment = await qe.select(
+          `
       SELECT id
       FROM segments
       WHERE id = $(segmentId)
     `,
-        {
-          segmentId: data.segmentId,
-        },
-      )
+          {
+            segmentId: data.segmentId,
+          },
+        )
+
+        if (segment.length === 0) {
+          // segment not found, skip adding this activity relation
+          continue
+        }
 
-      if (segment.length === 0) {
-        // segment not found, skip adding this activity relation
-        continue
+        checkedSegments.add(data.segmentId)
       }
 
       // check member exists
-      let member = await qe.select(
-        `
+      if (checkedMembers.has(data.memberId)) {
+        const resolved = checkedMembers.get(data.memberId)
+        if (resolved === null) {
+          // member not found, skip adding this activity relation
+          continue
+        }
+        data.memberId = resolved
+      } else {
+        let member = await qe.select(
+          `
       SELECT id
       FROM members
       WHERE id = $(memberId)
     `,
-        {
-          memberId: data.memberId,
-        },
-      )
+          {
+            memberId: data.memberId,
+          },
+        )
 
-      if (member.length === 0) {
-        // find member using identity
-        member = await qe.select(
-          `
+        if (member.length === 0) {
+          // find member using identity
+          member = await qe.select(
+            `
         SELECT "memberId"
         FROM "memberIdentities"
-        WHERE value = $(value) 
-          and platform = $(platform) 
+        WHERE value = $(value)
+          and platform = $(platform)
           and verified = true
           and "deletedAt" is null
         limit 1
       `,
-          {
-            value: data.username,
-            platform: data.platform,
-          },
-        )
-        if (member.length === 0) {
-          // member not found, skip adding this activity relation
-          continue
+            {
+              value: data.username,
+              platform: data.platform,
+            },
+          )
+          if (member.length === 0) {
+            checkedMembers.set(data.memberId, null)
+            // member not found, skip adding this activity relation
+            continue
+          } else {
+            checkedMembers.set(data.memberId, member[0].memberId)
+            data.memberId = member[0].memberId
+          }
         } else {
-          data.memberId = member[0].memberId
+          checkedMembers.set(data.memberId, data.memberId)
         }
       }
 
       if (data.organizationId !== undefined && data.organizationId !== null) {
-        const organization = await qe.select(
-          `
+        if (!checkedOrganizations.has(data.organizationId)) {
+          const organization = await qe.select(
+            `
         SELECT id
         FROM organizations
         WHERE id = $(organizationId)
       `,
-          {
-            organizationId: data.organizationId,
-          },
-        )
+            {
+              organizationId: data.organizationId,
+            },
+          )
 
-        if (organization.length === 0) {
-          data.organizationId = null
+          if (organization.length === 0) {
+            data.organizationId = null
+          } else {
+            checkedOrganizations.add(data.organizationId)
+          }
         }
       }
     }