Skip to content

Commit e52f121

Browse files
committed
fix: use common blacklist variable
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
1 parent 878193c commit e52f121

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

services/libs/data-access-layer/src/affiliations/index.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1+
import { BLACKLISTED_MEMBER_TITLES } from '../members/base'
12
import { QueryExecutor } from '../queryExecutor'
23

3-
const BLACKLISTED_TITLES = ['investor', 'mentor', 'board member']
4-
54
export interface IAffiliationPeriod {
65
organization: string
76
startDate: string | null
@@ -69,7 +68,7 @@ export async function findWorkExperiencesBulk(
6968
)
7069

7170
return rows.filter(
72-
(r) => !r.title || !BLACKLISTED_TITLES.some((t) => r.title?.toLowerCase().includes(t)),
71+
(r) => !r.title || !BLACKLISTED_MEMBER_TITLES.some((t) => r.title?.toLowerCase().includes(t)),
7372
)
7473
}
7574

services/libs/data-access-layer/src/members/base.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ export interface MemberUpdateInput {
9595
manuallyCreated?: boolean
9696
}
9797

98+
export const BLACKLISTED_MEMBER_TITLES = ['investor', 'mentor', 'board member']
99+
98100
export const MEMBER_MERGE_FIELDS = [
99101
'affiliations',
100102
'attributes',

services/libs/data-access-layer/src/members/segments.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ import { buildSegmentActivityTypes, isSegmentSubproject } from '../segments'
1212
import { prepareBulkInsert } from '../utils'
1313

1414
import { IMemberActivitySummary, IMemberSegmentAggregates } from './types'
15+
import { BLACKLISTED_MEMBER_TITLES } from './base'
16+
1517

1618
const log = getServiceChildLogger('members/segments')
1719

@@ -322,14 +324,13 @@ export async function findAllUnkownDatedOrganizations(
322324
return filterOutBlacklistedTitles(result)
323325
}
324326

325-
const BLACKLISTED_TITLES = ['Investor', 'Mentor', 'Board Member']
326327
function filterOutBlacklistedTitles(experiences: IWorkExperienceData[]): IWorkExperienceData[] {
327328
return experiences.filter(
328329
(row) =>
329330
!row.title ||
330331
(row.title !== null &&
331332
row.title !== undefined &&
332-
!BLACKLISTED_TITLES.some((t) => row.title.toLowerCase().includes(t.toLowerCase()))),
333+
!BLACKLISTED_MEMBER_TITLES.some((t) => row.title.toLowerCase().includes(t))),
333334
)
334335
}
335336

0 commit comments

Comments
 (0)