Skip to content

Commit f1421c2

Browse files
ulemonsclaude
andcommitted
fix: align stewards schema to array type and fix unstewardedOnly null filter
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
1 parent b7f1724 commit f1421c2

5 files changed

Lines changed: 19 additions & 13 deletions

File tree

backend/src/api/public/v1/packages/batchGetStewardship.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export async function batchGetStewardship(req: Request, res: Response): Promise<
3838
impact: detail.general.impact.impactScore,
3939
openVulns,
4040
stewardship: detail.stewardship.status,
41-
stewards: null,
41+
stewards: detail.stewardship.stewards,
4242
lastActivityAt: null,
4343
lastActivityDescription: null,
4444
}

backend/src/api/public/v1/packages/listPackages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export async function listPackages(req: Request, res: Response): Promise<void> {
4747
if (ecosystem && p.ecosystem !== ecosystem) return false
4848
if (lifecycle && p.lifecycle !== lifecycle) return false
4949
if (busFactor1Only && p.maintainerBusFactor !== 1) return false
50-
if (unstewardedOnly && p.stewardship !== 'unassigned') return false
50+
if (unstewardedOnly && p.stewardship !== null && p.stewardship !== 'unassigned') return false
5151
if (staleOnly) {
5252
const lastRelease = MOCK_DETAILS[p.purl]?.general.riskSignals.lastRelease
5353
if (!lastRelease || new Date(lastRelease) >= staleThreshold) return false

backend/src/api/public/v1/packages/mockData.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export interface MockPackageListItem {
99
lifecycle: Lifecycle
1010
maintainerBusFactor: number
1111
openVulns: OpenVulns
12-
stewardship: StewardshipStatus
13-
stewards: Steward | null
12+
stewardship: StewardshipStatus | null
13+
stewards: Steward[] | null
1414
}
1515

1616
export interface MockPackageDetail {
@@ -60,7 +60,7 @@ export interface MockPackageDetail {
6060
}
6161
stewardship: {
6262
status: StewardshipStatus
63-
stewards: Steward | null
63+
stewards: Steward[] | null
6464
lastActivityAt: string | null
6565
}
6666
history: Record<string, unknown>

backend/src/api/public/v1/packages/openapi.yaml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,11 @@ components:
136136
stewardship:
137137
$ref: '#/components/schemas/StewardshipStatus'
138138
stewards:
139-
description: Single steward or null. Empty in v1.
139+
description: Assigned stewards or null. Empty in v1.
140140
oneOf:
141-
- $ref: '#/components/schemas/Steward'
141+
- type: array
142+
items:
143+
$ref: '#/components/schemas/Steward'
142144
- type: 'null'
143145
lastActivityAt:
144146
type:
@@ -195,9 +197,11 @@ components:
195197
stewardship:
196198
$ref: '#/components/schemas/StewardshipStatus'
197199
stewards:
198-
description: Single assigned steward or null.
200+
description: Assigned stewards or null.
199201
oneOf:
200-
- $ref: '#/components/schemas/Steward'
202+
- type: array
203+
items:
204+
$ref: '#/components/schemas/Steward'
201205
- type: 'null'
202206

203207
# ── Package detail ───────────────────────────────────────────────────────────
@@ -419,9 +423,11 @@ components:
419423
status:
420424
$ref: '#/components/schemas/StewardshipStatus'
421425
stewards:
422-
description: Single assigned steward or null. Null in v1.
426+
description: Assigned stewards or null. Null in v1.
423427
oneOf:
424-
- $ref: '#/components/schemas/Steward'
428+
- type: array
429+
items:
430+
$ref: '#/components/schemas/Steward'
425431
- type: 'null'
426432
lastActivityAt:
427433
type:

backend/src/api/public/v1/packages/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ export interface StewardshipSummary {
3333
health: number | null
3434
impact: number | null
3535
openVulns: OpenVulns | null
36-
stewardship: StewardshipStatus
37-
stewards: Steward | null
36+
stewardship: StewardshipStatus | null
37+
stewards: Steward[] | null
3838
lastActivityAt: string | null
3939
lastActivityDescription: string | null
4040
}

0 commit comments

Comments
 (0)