fix: unmock stewardship

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>

Author: ulemons

backend/src/api/public/v1/packages/getPackage.ts

@@ -2,7 +2,11 @@ import type { Request, Response } from 'express'
 import { z } from 'zod'
 
 import { NotFoundError } from '@crowd/common'
-import { getAdvisoriesByPackageId, getPackageDetailByPurl } from '@crowd/data-access-layer'
+import {
+  getAdvisoriesByPackageId,
+  getPackageDetailByPurl,
+  getStewardshipSummary,
+} from '@crowd/data-access-layer'
 
 import { getPackagesQx } from '@/db/packagesDb'
 import { ok } from '@/utils/api'
@@ -30,7 +34,10 @@ export async function getPackage(req: Request, res: Response): Promise<void> {
     throw new NotFoundError()
   }
 
-  const advisories = await getAdvisoriesByPackageId(qx, pkg.id)
+  const [advisories, stewardshipSummary] = await Promise.all([
+    getAdvisoriesByPackageId(qx, pkg.id),
+    pkg.stewardshipId ? getStewardshipSummary(qx, pkg.stewardshipId) : null,
+  ])
 
   ok(res, {
     purl: pkg.purl,
@@ -84,8 +91,8 @@ export async function getPackage(req: Request, res: Response): Promise<void> {
     },
     stewardship: {
       status: (pkg.stewardshipStatus ?? 'unassigned') as StewardshipStatus,
-      stewards: null,
-      lastActivityAt: null,
+      stewards: stewardshipSummary?.stewards ?? null,
+      lastActivityAt: stewardshipSummary?.lastActivityAt ?? null,
     },
     history: {},
   })

services/libs/data-access-layer/src/osspckgs/api.ts

@@ -273,6 +273,7 @@ export interface PackageDetailRow {
   declaredRepositoryUrl: string | null
   repositoryUrl: string | null
   hasCriticalVulnerability: boolean
+  stewardshipId: string | null
   stewardshipStatus: string | null
   stewardshipLastStatusAt: Date | null
   // from package_repos + repos
@@ -315,6 +316,7 @@ export async function getPackageDetailByPurl(
       p.declared_repository_url AS "declaredRepositoryUrl",
       p.repository_url AS "repositoryUrl",
       p.has_critical_vulnerability AS "hasCriticalVulnerability",
+      s.id::text AS "stewardshipId",
       s.status AS "stewardshipStatus",
       s.last_status_at AS "stewardshipLastStatusAt",
       -- best repo link (highest confidence, prefer declared)

services/libs/data-access-layer/src/osspckgs/stewardships.ts

@@ -225,6 +225,45 @@ export async function assignSteward(
   })
 }
 
+export interface StewardshipSummary {
+  stewards: StewardshipStewardRecord[]
+  lastActivityAt: string | null
+}
+
+export async function getStewardshipSummary(
+  qx: QueryExecutor,
+  stewardshipId: string,
+): Promise<StewardshipSummary> {
+  const [stewards, activityRow] = await Promise.all([
+    qx.select(
+      `SELECT id, stewardship_id, user_id, role, assigned_at, assigned_by
+       FROM stewardship_stewards
+       WHERE stewardship_id = $(stewardshipId)
+         AND deleted_at IS NULL
+       ORDER BY assigned_at ASC`,
+      { stewardshipId },
+    ) as Promise<Array<Record<string, unknown>>>,
+    qx.selectOneOrNone(
+      `SELECT MAX(created_at) AS last_activity_at
+       FROM stewardship_activity
+       WHERE stewardship_id = $(stewardshipId)`,
+      { stewardshipId },
+    ) as Promise<Record<string, unknown> | null>,
+  ])
+
+  return {
+    stewards: stewards.map((s) => ({
+      id: String(s.id),
+      stewardshipId: String(s.stewardship_id),
+      userId: String(s.user_id),
+      role: String(s.role),
+      assignedAt: toIso(s.assigned_at),
+      assignedBy: s.assigned_by ? String(s.assigned_by) : null,
+    })),
+    lastActivityAt: activityRow?.last_activity_at ? toIso(activityRow.last_activity_at) : null,
+  }
+}
+
 export const ESCALATION_RESOLUTION_PATHS = [
   'lf_staff_review',
   'community_outreach',