fix: resolve pr comments from ai bots

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Author: skwowet

services/apps/cron_service/src/jobs/inferMemberOrganizationStintChanges.job.ts

@@ -82,21 +82,18 @@ const job: IJobDefinition = {
  */
 function parseMemberActivityHash(hash: Record<string, string>) {
   const orgIds = Object.keys(hash)
-  const activityDates = orgIds
-    .flatMap((organizationId) => {
-      try {
-        const dates = JSON.parse(hash[organizationId])
-        return Array.isArray(dates)
-          ? dates
-              .filter((d): d is string => typeof d === 'string')
-              .map((date) => ({ organizationId, date }))
-          : []
-      } catch {
-        return []
-      }
-    })
-    .sort((a, b) => a.date.localeCompare(b.date))
-
+  const activityDates = orgIds.flatMap((organizationId) => {
+    try {
+      const dates = JSON.parse(hash[organizationId])
+      return Array.isArray(dates)
+        ? dates
+            .filter((d): d is string => typeof d === 'string')
+            .map((date) => ({ organizationId, date }))
+        : []
+    } catch {
+      return []
+    }
+  })
   return { activityDates, orgIds }
 }
 

services/libs/common_services/src/services/member-organization.ts

@@ -152,7 +152,9 @@ export function inferMemberOrganizationStintChanges(
     isNew: false,
   }))
 
-  for (const { organizationId, date: targetDate } of orgDates) {
+  const sortedDates = [...orgDates].sort((a, b) => a.date.localeCompare(b.date))
+
+  for (const { organizationId, date: targetDate } of sortedDates) {
     const orgStints = stints.filter((s) => s.organizationId === organizationId)
 
     // 2. Skip if the date is already covered by an existing stint