Skip to content

Commit f8c4463

Browse files
committed
fix: comments
Signed-off-by: Uroš Marolt <uros@marolt.me>
1 parent ac2de8a commit f8c4463

4 files changed

Lines changed: 5 additions & 7 deletions

File tree

services/apps/packages_worker/src/deps-dev/activities/bqExportToGcs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ EXPORT DATA OPTIONS(
279279
return { gcsPrefix, rowCount, bqBytesBilled: bqStats.bqBytesBilled, jobId }
280280
} catch (err) {
281281
await markJobStatus(qx, jobId, 'failed', {
282-
errorMessage: (err as Error).message,
282+
errorMessage: err instanceof Error ? err.message : String(err),
283283
finishedAt: new Date(),
284284
})
285285
throw err

services/apps/packages_worker/src/deps-dev/activities/checkDependentCountsGuard.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import {
2-
OsspckgsJobKind,
3-
getLastCompletedJobRowCount as dalGetLastCompletedJobRowCount,
4-
} from '@crowd/data-access-layer'
1+
import { getLastCompletedJobRowCount as dalGetLastCompletedJobRowCount } from '@crowd/data-access-layer'
2+
import type { OsspckgsJobKind } from '@crowd/data-access-layer'
53
import { SlackChannel, SlackPersona, sendSlackNotification } from '@crowd/slack'
64

75
import { getPackagesDb } from '../../db'

services/apps/packages_worker/src/deps-dev/activities/gcsParquetToStaging.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export async function gcsParquetToStaging(input: GcsToStagingInput): Promise<Gcs
181181
return { rowsLoaded: totalLoaded }
182182
} catch (err) {
183183
await markJobStatus(qx, jobId, 'failed', {
184-
errorMessage: (err as Error).message,
184+
errorMessage: err instanceof Error ? err.message : String(err),
185185
finishedAt: new Date(),
186186
})
187187
throw err

services/apps/packages_worker/src/deps-dev/activities/mergeStagingToTable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export async function mergeStagingToTable(input: MergeStagingInput): Promise<Mer
101101
return { rowsAffected, tableRowCounts }
102102
} catch (err) {
103103
await markJobStatus(qx, jobId, 'failed', {
104-
errorMessage: (err as Error).message,
104+
errorMessage: err instanceof Error ? err.message : String(err),
105105
finishedAt: new Date(),
106106
})
107107
throw err

0 commit comments

Comments
 (0)