chore: add missing labels to activity types [IN-761]#3503
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
joanagmaia
left a comment
joanagmaia
left a comment
There was a problem hiding this comment.
Small suggestion and one typo.
Overall comment: we usually use U migration files for to revert, and V migration files to apply. I think the changes have it switched, can you make that update?
| UPDATE "activityTypes" SET label = 'Joined a server/guild' WHERE "activityType" = 'joined_guild' AND platform = 'discord'; | ||
| UPDATE "activityTypes" SET label = 'Message in a thread' WHERE "activityType" = 'thread_message' AND platform = 'discord'; | ||
| UPDATE "activityTypes" SET label = 'Started a thread' WHERE "activityType" = 'thread_started' AND platform = 'discord'; |
There was a problem hiding this comment.
- Would update label for type
thread_message-> "Sent a message in a thread"
There was a problem hiding this comment.
Good catch, I missed that one 👍
| UPDATE "activityTypes" SET label = 'Liked a post' WHERE "activityType" = 'like' AND platform = 'discourse'; | ||
| UPDATE "activityTypes" SET label = 'Joined a forum' WHERE "activityType" = 'join' AND platform = 'discourse'; | ||
| UPDATE "activityTypes" SET label = 'Created a topic' WHERE "activityType" = 'create_topic' AND platform = 'discourse'; | ||
| UPDATE "activityTypes" SET label = 'Replied to Topic' WHERE "activityType" = 'message_in_topic' AND platform = 'discourse'; |
There was a problem hiding this comment.
Would update label for type message_in_topic -> "Sent a message in topic"
| UPDATE "activityTypes" SET label = 'Unstarred a repository' WHERE "activityType" = 'unstar' AND platform = 'github'; | ||
|
|
||
| UPDATE "activityTypes" SET label = 'Forked a repository' WHERE "activityType" = 'fork' AND platform = 'gitlab'; | ||
| UPDATE "activityTypes" SET label = 'Assigned to a merge request Assigned' WHERE "activityType" = 'merge_request-assigned' AND platform = 'gitlab'; |
There was a problem hiding this comment.
Small typo: Remove last "Assigned"
Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com>
borfast
force-pushed
the
chore/IN-761-add-missing-labels-to-activity-types
branch
from
05edea8 to
637c12b
Compare
I copied the code from one file to the other to make the "down" migration, and must have edited the wrong file by mistake 🤦 |
joanagmaia
left a comment
joanagmaia
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for making the changes 🙏
2 participants
We were missing labels for some activity types. This PR adds them.