refactor: unify query building logic for merge suggestions [CM-765]#3581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR builds on the previous refactoring effort to further improve the merge suggestion query logic. The focus is on unifying the implementation for members and organizations to make it more robust and maintainable.
Before:
maxClauseCounterrors to persist in edge cases.After:
clauseBuilderspattern has been introduced to create a unified and DRY implementation for both member and organization queries.maxClauseCountissue for both members and organizations.isNumeric,cleanIdentityValue, etc.) have been extracted to improve clarity.EMAIL_AS_USERNAME_PLATFORMShave been moved to a centralenums.tsfile.This refactor ensures that the suggestion generation is both efficient and easier to maintain going forward, without affecting the quality of the results.