From bdbdc2099bfc5a1b56b2dbb2befdc9e9d741329b Mon Sep 17 00:00:00 2001
From: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Date: Mon, 10 Nov 2025 18:38:33 +0530
Subject: [PATCH] fix: handle non-array contributions in unmerge preview

Add explicit Array.isArray check for secondaryBackup.contributions
to prevent TypeError when contributions field is not an array.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
---
 backend/src/services/memberService.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/backend/src/services/memberService.ts b/backend/src/services/memberService.ts
index 125131afaf..987d5836b6 100644
--- a/backend/src/services/memberService.ts
+++ b/backend/src/services/memberService.ts
@@ -958,8 +958,11 @@ export default class MemberService extends LoggerBase {
               } else if (key === 'contributions') {
                 // check secondary member has any contributions to extract from current member
                 if (member.contributions && Array.isArray(member.contributions)) {
+                  const secondaryContributions = Array.isArray(secondaryBackup.contributions)
+                    ? secondaryBackup.contributions
+                    : []
                   member.contributions = member.contributions.filter(
-                    (c) => !(secondaryBackup.contributions || []).some((s) => s.id === c.id),
+                    (c) => !secondaryContributions.some((s) => s.id === c.id),
                   )
                 }
               } else if (