fix: profile worker dependencies import#3982
Conversation
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| import { proxyActivities } from '@temporalio/workflow' | ||
|
|
||
| import { parseLlmJson } from '@crowd/common' | ||
| import { parseLlmJson } from '@crowd/common/src/llm' |
There was a problem hiding this comment.
Unnecessary deep import bypasses package public API
Low Severity
The parseLlmJson function is already re-exported from @crowd/common via export * from './llm' in services/libs/common/src/index.ts. The new deep import @crowd/common/src/llm bypasses the package's public API and is the only such subpath import pattern in the entire codebase, making it inconsistent with all other @crowd/common imports. The original import was correct.
joanagmaia
left a comment
There was a problem hiding this comment.
Thanks for fixing this
There was a problem hiding this comment.
Pull request overview
Updates the profiles Temporal workflow to import parseLlmJson from its direct module path, likely to narrow the dependency surface for workflow bundling/runtime.
Changes:
- Switched
parseLlmJsonimport inprocessMemberBotAnalysisWithLLM.tsfrom@crowd/commonto@crowd/common/src/llm.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { proxyActivities } from '@temporalio/workflow' | ||
|
|
||
| import { parseLlmJson } from '@crowd/common' | ||
| import { parseLlmJson } from '@crowd/common/src/llm' |
There was a problem hiding this comment.
This introduces a deep import into @crowd/common/src/..., which couples the workflow to the internal folder structure of @crowd/common and can break if that package is later built/published without its src/ tree or adds an exports map. If the intent is to avoid pulling the full @crowd/common barrel into the Temporal workflow bundle, consider adding/using a stable public subpath entrypoint (e.g. @crowd/common/llm) instead of importing from src directly.
| import { parseLlmJson } from '@crowd/common/src/llm' | |
| import { parseLlmJson } from '@crowd/common/llm' |


This pull request makes a minor update to the import path for the
parseLlmJsonutility. The import now points directly to its location in the codebase, which helps clarify dependencies and may prevent issues with ambiguous or incorrect imports.parseLlmJsoninprocessMemberBotAnalysisWithLLM.tsto use the direct path@crowd/common/src/llminstead of the package root.Note
Low Risk
Low risk: this is a single import-path change with no behavioral or data-flow changes, aside from potential module resolution differences at build/runtime.
Overview
Adjusts the
processMemberBotAnalysisWithLLMworkflow to importparseLlmJsonfrom@crowd/common/src/llmrather than@crowd/common, making the dependency target explicit and avoiding ambiguous package-root exports.Written by Cursor Bugbot for commit f223fb5. This will update automatically on new commits. Configure here.