Skip to content

fix: profile worker dependencies import#3982

Merged
mbani01 merged 1 commit into
mainfrom
fix/profile_worker_deps_error
Mar 31, 2026
Merged

fix: profile worker dependencies import#3982
mbani01 merged 1 commit into
mainfrom
fix/profile_worker_deps_error

Conversation

@mbani01

@mbani01 mbani01 commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the import path for the parseLlmJson utility. The import now points directly to its location in the codebase, which helps clarify dependencies and may prevent issues with ambiguous or incorrect imports.

  • Updated the import statement for parseLlmJson in processMemberBotAnalysisWithLLM.ts to use the direct path @crowd/common/src/llm instead of the package root.

Note

Low Risk
Low risk: this is a single import-path change with no behavioral or data-flow changes, aside from potential module resolution differences at build/runtime.

Overview
Adjusts the processMemberBotAnalysisWithLLM workflow to import parseLlmJson from @crowd/common/src/llm rather than @crowd/common, making the dependency target explicit and avoiding ambiguous package-root exports.

Written by Cursor Bugbot for commit f223fb5. This will update automatically on new commits. Configure here.

Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
@mbani01 mbani01 requested a review from joanagmaia March 31, 2026 12:14
@mbani01 mbani01 self-assigned this Mar 31, 2026
Copilot AI review requested due to automatic review settings March 31, 2026 12:14
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

import { proxyActivities } from '@temporalio/workflow'

import { parseLlmJson } from '@crowd/common'
import { parseLlmJson } from '@crowd/common/src/llm'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary deep import bypasses package public API

Low Severity

The parseLlmJson function is already re-exported from @crowd/common via export * from './llm' in services/libs/common/src/index.ts. The new deep import @crowd/common/src/llm bypasses the package's public API and is the only such subpath import pattern in the entire codebase, making it inconsistent with all other @crowd/common imports. The original import was correct.

Fix in Cursor Fix in Web

@joanagmaia joanagmaia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the profiles Temporal workflow to import parseLlmJson from its direct module path, likely to narrow the dependency surface for workflow bundling/runtime.

Changes:

  • Switched parseLlmJson import in processMemberBotAnalysisWithLLM.ts from @crowd/common to @crowd/common/src/llm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import { proxyActivities } from '@temporalio/workflow'

import { parseLlmJson } from '@crowd/common'
import { parseLlmJson } from '@crowd/common/src/llm'

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a deep import into @crowd/common/src/..., which couples the workflow to the internal folder structure of @crowd/common and can break if that package is later built/published without its src/ tree or adds an exports map. If the intent is to avoid pulling the full @crowd/common barrel into the Temporal workflow bundle, consider adding/using a stable public subpath entrypoint (e.g. @crowd/common/llm) instead of importing from src directly.

Suggested change
import { parseLlmJson } from '@crowd/common/src/llm'
import { parseLlmJson } from '@crowd/common/llm'

Copilot uses AI. Check for mistakes.
@mbani01 mbani01 merged commit 7974bb1 into main Mar 31, 2026
23 checks passed
@mbani01 mbani01 deleted the fix/profile_worker_deps_error branch March 31, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants