Skip to content

fix: profile worker dependencies import #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbani01 merged 1 commit into from
Mar 31, 2026
+1 −1
Merged

fix: profile worker dependencies import #3982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/apps/profiles_worker/src/workflows/member/processMemberBotAnalysisWithLLM.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { proxyActivities } from '@temporalio/workflow'

import { parseLlmJson } from '@crowd/common'
import { parseLlmJson } from '@crowd/common/src/llm'

@cursor cursor Bot Mar 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary deep import bypasses package public API

Low Severity

The parseLlmJson function is already re-exported from @crowd/common via export * from './llm' in services/libs/common/src/index.ts. The new deep import @crowd/common/src/llm bypasses the package's public API and is the only such subpath import pattern in the entire codebase, making it inconsistent with all other @crowd/common imports. The original import was correct.

Fix in Cursor Fix in Web

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a deep import into @crowd/common/src/..., which couples the workflow to the internal folder structure of @crowd/common and can break if that package is later built/published without its src/ tree or adds an exports map. If the intent is to avoid pulling the full @crowd/common barrel into the Temporal workflow bundle, consider adding/using a stable public subpath entrypoint (e.g. @crowd/common/llm) instead of importing from src directly.

Suggested change
import { parseLlmJson } from '@crowd/common/src/llm'
import { parseLlmJson } from '@crowd/common/llm'

Copilot uses AI. Check for mistakes.
import { LlmQueryType } from '@crowd/types'

import * as activities from '../../activities'
Expand Down
Loading