Skip to content

chore: deprecate activityTasks and activities tables in postgres (CM-1007) #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themarolt merged 5 commits into from
May 7, 2026
Merged

chore: deprecate activityTasks and activities tables in postgres (CM-1007) #4086

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3891f6a
chore: deprecate activityTasks and activities tables in postgres
themarolt May 7, 2026
408007f
Merge branch 'main' into chore/drop-activities-table-CM-1007
themarolt May 7, 2026
a7143f1
fix: comment
themarolt May 7, 2026
9e49e31
Merge branch 'main' into chore/drop-activities-table-CM-1007
themarolt May 7, 2026
39689a7
chore: removed dead code
themarolt May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
326 changes: 0 additions & 326 deletions backend/src/bin/scripts/fix-auto-merged-orgs.ts
View file
Open in desktop

This file was deleted.

Empty file added backend/src/database/migrations/U1778146717__drop-activities-and-activity-tasks.sql
View file
Open in desktop
Empty file.
2 changes: 2 additions & 0 deletions backend/src/database/migrations/V1778146717__drop-activities-and-activity-tasks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
DROP TABLE IF EXISTS "activityTasks";
DROP TABLE IF EXISTS "activities";
Comment thread
themarolt marked this conversation as resolved.
Comment thread
themarolt marked this conversation as resolved.
33 changes: 7 additions & 26 deletions backend/src/database/repositories/memberRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,12 +937,12 @@ class MemberRepository {
})

if (data.length > 0 && data[0].memberId !== record.id) {
let memberSegment = (await seq.query(
const memberSegment = (await seq.query(
`
select distinct a."segmentId", a."memberId"
from activities a where a."memberId" = :memberId
limit 1
`,
select distinct ms."segmentId", ms."memberId"
from "memberSegments" ms where ms."memberId" = :memberId
limit 1
`,
{
replacements: {
memberId: data[0].memberId,
Expand All @@ -952,27 +952,8 @@ class MemberRepository {
},
)) as any[]

// if there's no activity for the member, check memberSegments table
if (memberSegment.length === 0) {
memberSegment = (await seq.query(
Comment thread
cursor[bot] marked this conversation as resolved.
`
select distinct ms."segmentId", ms."memberId"
from "memberSegments" ms where ms."memberId" = :memberId
limit 1
`,
{
replacements: {
memberId: data[0].memberId,
},
type: QueryTypes.SELECT,
transaction,
},
)) as any[]

// still not found, throw an error
if (!memberSegment) {
throw new Error('Member with same identity already exists!')
}
if (!memberSegment) {
throw new Error('Member with same identity already exists!')
}
Comment thread
themarolt marked this conversation as resolved.

const segmentInfo = (await seq.query(
Expand Down
Loading
Loading