Skip to content

fix: improve career break inference in stint changes#4087

Merged
skwowet merged 3 commits intomainfrom
hotfix-infer-member-org-changes
May 7, 2026
Merged

fix: improve career break inference in stint changes#4087
skwowet merged 3 commits intomainfrom
hotfix-infer-member-org-changes

Conversation

@skwowet
Copy link
Copy Markdown
Collaborator

@skwowet skwowet commented May 7, 2026

Note

Medium Risk
Changes stint-splitting heuristics when inferring member org career breaks, which can alter generated/updated affiliation date ranges in production data. Logic is localized but affects core inference outcomes.

Overview
Adjusts career-break (stint split) detection in inferMemberOrganizationStintChanges when another organization overlaps the gap between dates.

Instead of always treating “umbrella” orgs (those that wrap the neighboring stint) as non-separators, they can now separate stints only if they occupy the gap for more than 90 days (vs the existing 30-day threshold for normal overlaps), and the overlap check is made explicit by early-returning when there is no positive overlap.

Reviewed by Cursor Bugbot for commit b1fadf9. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
@skwowet skwowet self-assigned this May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 13:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the stint-change inference logic used by the email-domain member-organization pipeline to better distinguish true career breaks from “umbrella” organizations that span neighboring stints, reducing false split/merge behavior.

Changes:

  • Adds an early guard to ignore non-overlapping gap intersections (overlapStart >= overlapEnd).
  • Changes “umbrella org” handling from “never a separator” to “separator only if it overlaps the gap for >90 days” (vs >30 days for non-umbrella orgs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread services/libs/common_services/src/services/member-organization.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@skwowet skwowet merged commit b1115b3 into main May 7, 2026
15 checks passed
@skwowet skwowet deleted the hotfix-infer-member-org-changes branch May 7, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants