Skip to content

fix: improve career break inference in stint changes #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 3 commits into from
May 7, 2026
+6 −6
Merged

fix: improve career break inference in stint changes #4087

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa61f7d
fix: improve career break inference in stint changes
skwowet May 7, 2026
ef0299d
Merge branch 'main' into hotfix-infer-member-org-changes
skwowet May 7, 2026
b1fadf9
fix: resolve pr review comments
skwowet May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions services/libs/common_services/src/services/member-organization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,15 @@ export function inferMemberOrganizationStintChanges(
return false
}

// Wide umbrella orgs that fully wrap the neighbor are concurrent, not career breaks
if (s.dateStart <= neighbor.dateStart && s.dateEnd >= neighbor.dateEnd) {
return false
}

const overlapStart = s.dateStart > gapStart ? s.dateStart : gapStart
const overlapEnd = s.dateEnd < gapEnd ? s.dateEnd : gapEnd
if (overlapStart >= overlapEnd) return false

// Wrapping orgs were already concurrent, so need >90d (vs >30d) to separate
const isUmbrella = s.dateStart <= neighbor.dateStart && s.dateEnd >= neighbor.dateEnd
const threshold = isUmbrella ? 90 : 30

return overlapStart < overlapEnd && diff(overlapStart, overlapEnd) > 30
return diff(overlapStart, overlapEnd) > threshold
})

if (hasSeparator) {
Expand Down
Loading