fix: remove dead code from DAL (CM-1138)#4120
Merged
Merged
Conversation
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-obsolete evaluated-projects data-access-layer module after the underlying evaluatedProjects table was removed/refactored out of the database schema, reducing dead code and keeping the DAL surface area aligned with current storage.
Changes:
- Removed the
evaluated-projectsbarrel export from the DAL root index. - Deleted the
evaluated-projectsDAL module (types + query helpers).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/libs/data-access-layer/src/index.ts | Stops re-exporting the removed evaluated-projects module. |
| services/libs/data-access-layer/src/evaluated-projects/types.ts | Deletes evaluated-projects DB type definitions. |
| services/libs/data-access-layer/src/evaluated-projects/index.ts | Removes the evaluated-projects module barrel exports. |
| services/libs/data-access-layer/src/evaluated-projects/evaluatedProjects.ts | Deletes evaluated-projects query/CRUD helpers referencing the dropped table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the Evaluated projects table was removed because it was useless
Changes
Remove evaluated projects DAL.
Type of change
Note
Low Risk
Low risk cleanup that deletes unused DAL code and exports; risk is limited to any external consumers still importing the removed
evaluated-projectsAPIs.Overview
Removes the
evaluated-projectsdata-access module entirely (types plus all CRUD/query helpers for the"evaluatedProjects"table), including join helpers likefindPendingEvaluatedProjectsWithCatalog.Updates the DAL barrel export (
src/index.ts) to stop re-exporting./evaluated-projects, effectively making these APIs unavailable to downstream imports.Reviewed by Cursor Bugbot for commit 7d0503a. Bugbot is set up for automated code reviews on this repo. Configure here.