Skip to content

fix: remove dead code from DAL (CM-1138)#4120

Merged
ulemons merged 1 commit into
mainfrom
fix/remove-dead-code-for-evaluated-projects
May 15, 2026
Merged

fix: remove dead code from DAL (CM-1138)#4120
ulemons merged 1 commit into
mainfrom
fix/remove-dead-code-for-evaluated-projects

Conversation

@ulemons

@ulemons ulemons commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

the Evaluated projects table was removed because it was useless

Changes

Remove evaluated projects DAL.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Note

Low Risk
Low risk cleanup that deletes unused DAL code and exports; risk is limited to any external consumers still importing the removed evaluated-projects APIs.

Overview
Removes the evaluated-projects data-access module entirely (types plus all CRUD/query helpers for the "evaluatedProjects" table), including join helpers like findPendingEvaluatedProjectsWithCatalog.

Updates the DAL barrel export (src/index.ts) to stop re-exporting ./evaluated-projects, effectively making these APIs unavailable to downstream imports.

Reviewed by Cursor Bugbot for commit 7d0503a. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
Copilot AI review requested due to automatic review settings May 15, 2026 09:08
@ulemons ulemons self-assigned this May 15, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-obsolete evaluated-projects data-access-layer module after the underlying evaluatedProjects table was removed/refactored out of the database schema, reducing dead code and keeping the DAL surface area aligned with current storage.

Changes:

  • Removed the evaluated-projects barrel export from the DAL root index.
  • Deleted the evaluated-projects DAL module (types + query helpers).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
services/libs/data-access-layer/src/index.ts Stops re-exporting the removed evaluated-projects module.
services/libs/data-access-layer/src/evaluated-projects/types.ts Deletes evaluated-projects DB type definitions.
services/libs/data-access-layer/src/evaluated-projects/index.ts Removes the evaluated-projects module barrel exports.
services/libs/data-access-layer/src/evaluated-projects/evaluatedProjects.ts Deletes evaluated-projects query/CRUD helpers referencing the dropped table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ulemons ulemons merged commit 19cae0e into main May 15, 2026
22 checks passed
@ulemons ulemons deleted the fix/remove-dead-code-for-evaluated-projects branch May 15, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants