fix: remove display name equality merge signal (CM-1137)#4160
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced “exact display name match” similarity boost in MemberSimilarityCalculator, addressing a high false-positive rate (common-name collisions) that caused an excessive volume of merge suggestions and downstream LLM gating cost.
Changes:
- Removed the display-name-equality early return path from the similarity calculation.
- Kept the git-username-clash relaxation logic, with a small rename/clarification of the helper used to decide when display names are too generic to relax clashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skwowet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the display name equality check introduced in #4115 and #4123 as a similarity signal for member merge suggestions.
Display name matching ended up creating a much larger blast radius than expected, generating ~1M merge suggestions, most of which were false positives caused by different people sharing common names. While the LLM gate filtered many of these out, it came at a significant cost and produced a poor signal-to-noise ratio.
Rather than continuing to refine display name matching, we'll focus on improving the similarity algorithm incrementally using narrow, high-precision signals where the impact is easier to reason about and validate.