fix: skip bot members from stint inference and lfid enrichment (CM-1260) - #4227
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens bot/organization-member exclusion across enrichment and email-domain stint inference to prevent bot members from being queued for stint inference (and related downstream affiliation refreshes), and to align LFID enrichment with the main enrichment pipeline’s exclusion rules.
Changes:
- Exclude bot and organization members in
fetchMembersForLFIDEnrichmentviamembers.attributesflags. - Fix bot detection during member updates by relying on persisted DB state (
original.attributes) instead of the potentially-empty update payload. - Prevent stint-inference buffering for bot members when assigning organizations by email domain.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/libs/data-access-layer/src/old/apps/members_enrichment_worker/index.ts | Adds isBot/isOrganization filters to LFID enrichment selection query. |
| services/apps/data_sink_worker/src/service/member.service.ts | Uses DB state to detect bot members during updates and avoids queuing stint inference for bots when assigning orgs by email domain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bot members were incorrectly enqueued for email-domain stint inference, which created
memberOrganizationsand triggered affiliation refreshes they should not have. LFID enrichment also did not exclude bot members, unlike the main enrichment pipeline.Changes