Skip to content

fix: skip bot members from stint inference and lfid enrichment (CM-1260) #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 1 commit into from
Jun 17, 2026
Merged

fix: skip bot members from stint inference and lfid enrichment (CM-1260) #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions services/apps/data_sink_worker/src/service/member.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,10 @@ export default class MemberService extends LoggerBase {
}
}

const isBotMember = this.botDetectionService.isFlaggedAsBot(
attributes as Record<string, unknown>,
)

const emailIdentities = data.identities.filter(
(i) => i.type === MemberIdentityType.EMAIL && i.verified,
)
Expand All @@ -514,6 +518,7 @@ export default class MemberService extends LoggerBase {
orgPromiseCache,
effectiveMemberId,
activityTimestamp,
isBotMember,
),
this.log,
'memberService -> create -> assignOrganizationByEmailDomain',
Expand Down Expand Up @@ -693,7 +698,11 @@ export default class MemberService extends LoggerBase {
}
}

if (this.botDetectionService.isFlaggedAsBot(toUpdate.attributes)) {
const isBotMember = this.botDetectionService.isFlaggedAsBot(
original.attributes as Record<string, unknown>,
)

if (isBotMember) {
this.log.debug({ memberId: id }, 'Skipping organization creation for bot member')
return effectiveMemberId !== id ? effectiveMemberId : undefined
}
Expand Down Expand Up @@ -752,6 +761,7 @@ export default class MemberService extends LoggerBase {
orgPromiseCache,
effectiveMemberId,
activityTimestamp,
isBotMember,
),
this.log,
'memberService -> update -> assignOrganizationByEmailDomain',
Expand Down Expand Up @@ -807,6 +817,7 @@ export default class MemberService extends LoggerBase {
orgPromiseCache?: Map<string, Promise<string | undefined>>,
memberId?: string,
activityTimestamp?: string,
isBotMember = false,
): Promise<IOrganizationIdSource[]> {
const orgService = new OrganizationService(this.store, this.log)
const organizations: IOrganizationIdSource[] = []
Expand Down Expand Up @@ -866,7 +877,8 @@ export default class MemberService extends LoggerBase {
id: orgId,
source: orgSource,
})
if (memberId && activityTimestamp) {

if (memberId && activityTimestamp && !isBotMember) {
await this.bufferMemberOrganizationActivityDates(memberId, orgId, activityTimestamp)
}
}
Expand Down
2 changes: 2 additions & 0 deletions services/libs/data-access-layer/src/old/apps/members_enrichment_worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ export async function fetchMembersForLFIDEnrichment(db: DbStore, limit: number,
(mi.type = 'email' and mi.verified)
)
AND members."deletedAt" IS NULL
AND coalesce((members.attributes -> 'isBot' ->> 'default')::boolean, false) = false
AND coalesce((members.attributes -> 'isOrganization' ->> 'default')::boolean, false) = false
${idFilter}
GROUP BY members.id
ORDER BY members.id desc
Expand Down
Loading