fix: prevent member identity existence check from timing out

[skwowet]

Summary

Fixes 500 query timeouts on PUT /member/:memberId/identity caused by checkMemberIdentityExistence performing a full table scan on ~25M rows. The check now uses an indexed query aligned with DB unique constraints and returns 409 quickly when an identity already exists on another profile.

Changes

• Rewrite checkMemberIdentityExistence to require type and query by platform, type, and lower(value)
• Pass type from create, createMultiple, and update in memberIdentityService
• On update, return 404 when the identity id is not found, resolve the effective identity key from the patch and current row, and only 409 when a different member owns the identity

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.

[Copilot]

Pull request overview

This PR addresses PUT /member/:memberId/identity 500s caused by a slow checkMemberIdentityExistence query by rewriting it to use an indexed lookup on (platform, type, lower(value)) and updating backend call sites to always pass type, plus improving update behavior (404 on missing identity id; 409 only when another member owns the identity).

Changes:

• Rewrote checkMemberIdentityExistence to require type and query by platform, type, and lower(value) (matching existing indexes for active identities).
• Updated MemberIdentityService create/createMultiple/update to pass type, and improved update conflict detection + missing-id handling (404).
• Minor response-shaping changes for the existence-check query (now selects only id + memberId).

Note: the PR title is missing the required JIRA key suffix format type: description (CM-XXX) per .claude/rules/commit-workflow.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
services/libs/data-access-layer/src/members/identities.ts	Updates the identity existence query to be index-friendly and requires type.
backend/src/services/member/memberIdentityService.ts	Threads type into existence checks and improves update behavior (404/409 handling).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.