Skip to content

fix: remove unnecessary grouped lookup in verify work experience #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 9 commits into from
Jul 8, 2026
Merged

fix: remove unnecessary grouped lookup in verify work experience #4317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95a56a7
fix: avoid grouping when resolving work experience by id
skwowet Jul 8, 2026
5bd71f2
fix: remove unnecessary grouped lookup in verify work experience
skwowet Jul 8, 2026
973aae5
fix: enhance work experience verification with fallback organization …
skwowet Jul 8, 2026
38bdf05
fix: include grouped organization fallback in work experience verific…
skwowet Jul 8, 2026
3bf94b9
Merge branch 'main' into fix/cm-1266-hidden-work-exp-lookup
skwowet Jul 8, 2026
e524553
fix: streamline work experience verification with new resolution func…
skwowet Jul 8, 2026
9923101
refactor: no need to handle edge cases with hidden mo id
skwowet Jul 8, 2026
b03256b
fix: make prettier and linter happy
skwowet Jul 8, 2026
4d4ed5c
fix: resolve pr review comments
skwowet Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions backend/src/api/public/v1/members/work-experiences/updateMemberWorkExperience.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,11 @@ export async function updateMemberWorkExperience(req: Request, res: Response): P

const orgsMap = await fetchManyMemberOrgsWithOrgData(qx, [memberId], { withDomains: true })

const updatedMo = groupMemberOrganizations(orgsMap.get(memberId) ?? []).find(
(mo) => mo.id === workExperienceId,
)
const memberOrgsWithData = orgsMap.get(memberId) ?? []

const updatedMo =
groupMemberOrganizations(memberOrgsWithData).find((mo) => mo.id === workExperienceId) ??
memberOrgsWithData.find((mo) => mo.id === workExperienceId)

if (!updatedMo) {
throw new NotFoundError('Work experience not found')
Expand Down
10 changes: 6 additions & 4 deletions backend/src/api/public/v1/members/work-experiences/verifyMemberWorkExperience.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ export async function verifyMemberWorkExperience(req: Request, res: Response): P
withDomains: true,
})

const workExperienceWithOrgData = groupMemberOrganizations(
orgsMapBeforeChange.get(memberId) ?? [],
).find((mo) => mo.id === workExperienceId)
const memberOrgsWithData = orgsMapBeforeChange.get(memberId) ?? []

const workExperienceWithOrgData = memberOrgsWithData.find((mo) => mo.id === workExperienceId)

if (!workExperienceWithOrgData) {
throw new NotFoundError('Work experience not found')
Expand Down Expand Up @@ -114,8 +114,10 @@ export async function verifyMemberWorkExperience(req: Request, res: Response): P

const orgsMap = await fetchManyMemberOrgsWithOrgData(qx, [memberId], { withDomains: true })

const memberOrgsWithDataAfterChange = orgsMap.get(memberId) ?? []

const responseMo: IMemberRoleWithOrganization = groupMemberOrganizations(
orgsMap.get(memberId) ?? [],
memberOrgsWithDataAfterChange,
).find((mo) => mo.id === workExperienceId) ?? {
...workExperienceWithOrgData,
...updatedMemberOrg,
Expand Down
Loading