chore: deprecate rubygems-dependents-ingest workflow - #4339
Conversation
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
PR SummaryLow Risk Overview Worker & Temporal: Drops Implementation cleanup: Deletes Reviewed by Cursor Bugbot for commit 2d800af. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Pull request overview
Removes the legacy RubyGems reverse-dependency ingestion path while retaining core and critical RubyGems ingestion.
Changes:
- Removes the Temporal workflow, activity, and schedule registration.
- Deletes reverse-dependency fetching and database update logic.
- Removes related configuration and exports.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
services/libs/data-access-layer/src/osspckgs/rubygems.ts |
Removes dependent-count DAL functions. |
services/apps/packages_worker/src/workflows/index.ts |
Removes workflow export. |
services/apps/packages_worker/src/rubygems/workflows.ts |
Removes dependents workflow. |
services/apps/packages_worker/src/rubygems/schedule.ts |
Removes schedule definition. |
services/apps/packages_worker/src/rubygems/runRubyGemsDependentsLoop.ts |
Deletes processing loop. |
services/apps/packages_worker/src/rubygems/client.ts |
Removes reverse-dependencies API call. |
services/apps/packages_worker/src/rubygems/activities.ts |
Removes dependents activity. |
services/apps/packages_worker/src/config.ts |
Removes dependents configuration. |
services/apps/packages_worker/src/bin/rubygems-worker.ts |
Stops registering the schedule. |
services/apps/packages_worker/src/activities.ts |
Removes activity export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request removes all code related to fetching and processing RubyGems dependents data from the
packages_workerservice. The dependent count ingestion workflow, its scheduling, configuration, and all related activities and database functions have been deleted. The service will no longer attempt to fetch or store RubyGems reverse dependency information.The most important changes are:
Removal of RubyGems dependents ingestion workflow and scheduling:
ingestRubyGemsDependentsworkflow and its registration from the workflows index (workflows/index.ts,rubygems/workflows.ts). [1] [2]rubygems/schedule.ts). [1] [2]Removal of RubyGems dependents processing logic:
processRubyGemsDependentsBatchactivity and all related code from the activities export, implementation, and configuration (activities.ts,rubygems/activities.ts,config.ts). [1] [2] [3] [4]runRubyGemsDependentsLoop.tsfile, which contained the logic for fetching reverse dependencies and updating the database.Cleanup of RubyGems dependents client and data access:
fetchReverseDependenciesclient function from the RubyGems API client (rubygems/client.ts).data-access-layer/src/osspckgs/rubygems.ts).