fix: generate UUID when member identity id is empty on create - #4341
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes identity creation failures by preventing empty UUIDs from reaching PostgreSQL.
Changes:
- Generates a UUID for missing or empty identity IDs in the DAL.
- Adds a dedicated frontend creation type and omits IDs from create requests.
- Updates store and API-service contracts accordingly.
Review note: The PR title is missing the required JIRA key suffix, such as (CM-1234).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
services/libs/data-access-layer/src/members/identities.ts |
Handles empty IDs defensively. |
frontend/src/modules/contributor/types/Contributor.ts |
Defines the create payload type. |
frontend/src/modules/contributor/store/contributor.actions.ts |
Applies the create type to the store action. |
frontend/src/modules/contributor/services/contributor.identities.api.service.ts |
Applies the create type to the API request. |
frontend/src/modules/contributor/components/edit/identity/contributor-identity-add.vue |
Removes IDs from submitted identities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 500 errors on
PUT /member/:memberId/identitywhen users add identities from the Contributor UI. New identity rows were sent withid: "", which bypassed?? generateUUIDv1()and caused Postgres to reject the insert (invalid input syntax for type uuid: "").Changes
services/libs/data-access-layer/src/members/identities.ts): Usei.id || generateUUIDv1()ininsertMemberIdentitiesso empty/falsy ids get a generated UUID.contributor-identity-add.vue): Stripidfrom the create payload so new identities are sent without an id, matching theNewMemberIdentitycontract.