Skip to content

fix: memberToMerge and memberToMergeRaw fall out of sync (CM-1339) #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joanagmaia wants to merge 3 commits into from
Closed

fix: memberToMerge and memberToMergeRaw fall out of sync (CM-1339) #4347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e2cb2f
fix: memberToMerge and memberToMergeRaw fall out of sync (CM-1339)
joanagmaia Jul 15, 2026
cfa7350
Merge branch 'main' into fix/CM-1339-member-merge-raw-table-sync
joanagmaia Jul 15, 2026
97fd8b9
revert: undo dead code fix in enrichment worker addMemberToMerge (CM-…
joanagmaia Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions services/libs/data-access-layer/src/member_merge/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,17 @@ export async function removeMemberToMerge(
toMergeId,
},
)
await qx.result(
`
DELETE FROM "memberToMergeRaw"
WHERE "memberId" = $(memberId)
AND "toMergeId" = $(toMergeId)
Comment on lines +21 to +23
`,
Comment on lines +20 to +24
{
memberId,
toMergeId,
},
)
}

export async function addMemberNoMerge(
Expand Down
7 changes: 6 additions & 1 deletion services/libs/data-access-layer/src/old/apps/members_enrichment_worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,12 @@ export async function findExistingMember(
export async function addMemberToMerge(tx: DbTransaction, memberId: string, toMergeId: string) {
await tx.query(
`INSERT INTO "memberToMerge" ("memberId", "toMergeId", similarity)
VALUES ($1, $2, $3);"`,
VALUES ($1, $2, $3) ON CONFLICT DO NOTHING`,
[memberId, toMergeId, 0.9],
)
await tx.query(
`INSERT INTO "memberToMergeRaw" ("memberId", "toMergeId", similarity)
VALUES ($1, $2, $3) ON CONFLICT DO NOTHING`,
[memberId, toMergeId, 0.9],
)
}
Expand Down
Loading