Skip to content

Commit 41fedd9

Browse files
Merge pull request #5012 from linuxfoundation/unicron-update-comment-message-for-intercom
Update comment text & link for intercom integration needed by May 6th
2 parents ef19d05 + 0862807 commit 41fedd9

5 files changed

Lines changed: 17 additions & 18 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ cla-backend-go/golang-api.log
276276
utils/otel_dd_go/otel_dd
277277
audit.json
278278
spans*.json
279-
*api_usage.csv
279+
*api_usage*.csv
280280

281281
*.exe
282282
*.exe~

cla-backend-go/github/github_repository.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2150,7 +2150,7 @@ func getCommentBody(repositoryType, signURL string, signed, missing []*UserCommi
21502150

21512151
// ---------- Missing section (group by author) ----------
21522152
if numMissing > 0 {
2153-
supportURL := "https://jira.linuxfoundation.org/servicedesk/customer/portal/4"
2153+
supportURL := "https://easycla.lfx.linuxfoundation.org/"
21542154
missingIDHelpURL := "https://linuxfoundation.atlassian.net/wiki/spaces/LP/pages/160923756/Missing+ID+on+Commit+but+I+have+an+agreement+on+file"
21552155
githubHelpURL := "https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user"
21562156

@@ -2190,7 +2190,7 @@ func getCommentBody(repositoryType, signURL string, signed, missing []*UserCommi
21902190
"<a href='%s' target='_blank'>GitHub Help</a> to resolve. "+
21912191
"(To view the commit's email address, add .patch at the end of this PR page's URL.) "+
21922192
"For further assistance with EasyCLA, "+
2193-
"<a href='%s' target='_blank'>please submit a support request ticket</a>.</li>",
2193+
"<a href='%s' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot.</li>",
21942194
failed, strings.Join(shas, ", "), missingIDHelpURL, githubHelpURL, supportURL,
21952195
))
21962196
continue
@@ -2214,7 +2214,7 @@ func getCommentBody(repositoryType, signURL string, signed, missing []*UserCommi
22142214
`<li>%s %s (%s). This user is authorized, but they must confirm their affiliation with their company. `+
22152215
`Start the authorization process <a href='%s' target='_blank'> by clicking here</a>, `+
22162216
`click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. `+
2217-
`For further assistance with EasyCLA, <a href='%s' target='_blank'>please submit a support request ticket</a>.</li>`,
2217+
`For further assistance with EasyCLA, <a href='%s' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot.</li>`,
22182218
failed, authorInfo, strings.Join(shas, ", "),
22192219
signURL, supportURL,
22202220
))
@@ -2228,7 +2228,7 @@ func getCommentBody(repositoryType, signURL string, signed, missing []*UserCommi
22282228
committersComment.WriteString(fmt.Sprintf(
22292229
`<li><a href='%s' target='_blank'>%s</a> - %s. The commit (%s) is not authorized under a signed CLA. `+
22302230
`<a href='%s' target='_blank'>Please click here to be authorized</a>. `+
2231-
`For further assistance with EasyCLA, <a href='%s' target='_blank'>please submit a support request ticket</a>.</li>`,
2231+
`For further assistance with EasyCLA, <a href='%s' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot.</li>`,
22322232
signURL, failed, authorInfo, strings.Join(shas, ", "),
22332233
signURL, supportURL,
22342234
))

cla-backend-go/v2/gitlab-activity/service.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func PrepareMrCommentContent(missingUsers []*gatedGitlabUser, signedUsers []*git
346346
}
347347

348348
// gitlabSupportURL := "https://about.gitlab.com/support"
349-
easyCLASupportURL := "https://jira.linuxfoundation.org/servicedesk/customer/portal/4"
349+
easyCLASupportURL := "https://easycla.lfx.linuxfoundation.org/"
350350
// faq := "https://docs.linuxfoundation.org/lfx/easycla/v2-current/getting-started/easycla-troubleshooting#github-unable-to-contribute-to-easycla-enforced-repositories"
351351

352352
if len(missingUsers) > 0 {
@@ -358,14 +358,14 @@ func PrepareMrCommentContent(missingUsers []*gatedGitlabUser, signedUsers []*git
358358
Start the authorization process <a href='%s'> by clicking here</a>, click "Corporate",
359359
select the appropriate company from the list, then confirm your affiliation on the page that appears.
360360
For further assistance with EasyCLA,
361-
<a href='%s' target='_blank'>please submit a support request ticket</a>. </li>`, failed, authorInfo, signURL, easyCLASupportURL)
361+
<a href='%s' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot.</li>`, failed, authorInfo, signURL, easyCLASupportURL)
362362
result += msg
363363
body = confirmationNeededBadge
364364
} else {
365365
msg := fmt.Sprintf(`<li><a href='%s' target='_blank'>%s</a> - %s. The commit is not authorized under a signed CLA.
366366
<a href='%s' target='_blank'>Please click here to be authorized</a>.
367367
For further assistance with EasyCLA,
368-
<a href='%s' target='_blank'>please submit a support request ticket</a>.
368+
<a href='%s' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot.
369369
</li>`, signURL, failed, authorInfo, signURL, easyCLASupportURL)
370370
result += msg
371371
body = failedBadge

cla-backend/cla/tests/unit/test_github.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
SUCCESS = ":white_check_mark:"
1313
FAILED = ":x:"
1414
SIGN_URL = "http://test.contributor.lfcla/sign"
15-
SUPPORT_URL = "https://jira.linuxfoundation.org/servicedesk/customer/portal/4"
15+
SUPPORT_URL = "https://easycla.lfx.linuxfoundation.org/"
1616
GITHUB_HELP_URL = (
1717
"https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user"
1818
)
@@ -36,12 +36,11 @@
3636
# + f"is missing the User's ID, preventing the EasyCLA check. "
3737
# + f"<a href='{GITHUB_HELP_URL}' target='_blank'>Consult GitHub Help</a> to resolve."
3838
# + f"For further assistance with EasyCLA, "
39-
# + f"<a href='{SUPPORT_URL}' target='_blank'>please submit a support request ticket</a>."
39+
# + f"<a href='{SUPPORT_URL}' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot."
4040
# + "</li></url>"
4141
# )
4242
# assert response == expected
4343

44-
4544
# def test_get_comment_body_cla_fail_no_user_id_and_user_id():
4645
# """
4746
# Test CLA comment body for case CLA fail check with no user id and existing user id
@@ -63,14 +62,14 @@
6362
# + " ,".join([GITHUB_FAKE_SHA])
6463
# + ") is not authorized under a signed CLA. "
6564
# + f"[Please click here to be authorized]({SIGN_URL}). For further assistance with "
66-
# + f"EasyCLA, [please submit a support request ticket]({SUPPORT_URL})."
65+
# + f"EasyCLA, [please visit our EasyCLA portal]({SUPPORT_URL}) and chat with our support bot."
6766
# + "</li>"
6867
# + "<li> " + FAILED + " The commit ("
6968
# + " ,".join([GITHUB_FAKE_SHA_2])
7069
# + ") is missing the User's ID, preventing the EasyCLA check. [Consult GitHub Help]("
7170
# + GITHUB_HELP_URL
7271
# + ") to resolve. For further assistance with EasyCLA, "
73-
# + f"[please submit a support request ticket]({SUPPORT_URL})."
72+
# + f"[please visit our EasyCLA portal]({SUPPORT_URL}) and chat with our support bot."
7473
# + "</li></ul>"
7574
# )
7675
#
@@ -93,7 +92,7 @@
9392
# + f'[Start the authorization process by clicking here]({SIGN_URL}), click "Corporate",'
9493
# + "select the appropriate company from the list, then confirm "
9594
# + "your affiliation on the page that appears. For further assistance with EasyCLA, "
96-
# + f"[please submit a support request ticket]({SUPPORT_URL})."
95+
# + f"[please visit our EasyCLA portal]({SUPPORT_URL}) and chat with our support bot."
9796
# + "</li>"
9897
# + "</ul>"
9998
# )

cla-backend/cla/utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,7 +1136,7 @@ def get_comment_body(repository_type, sign_url, signed: List[UserCommitSummary],
11361136
committers_comment += f'<li>{success} {author_info} ({", ".join(commit_shas)})</li>'
11371137

11381138
if num_missing > 0:
1139-
support_url = "https://jira.linuxfoundation.org/servicedesk/customer/portal/4"
1139+
support_url = "https://easycla.lfx.linuxfoundation.org/"
11401140
missing_id_help_url = "https://linuxfoundation.atlassian.net/wiki/spaces/LP/pages/160923756/Missing+ID+on+Commit+but+I+have+an+agreement+on+file"
11411141

11421142
# Build a lookup table to group all the commits by author.
@@ -1166,7 +1166,7 @@ def get_comment_body(repository_type, sign_url, signed: List[UserCommitSummary],
11661166
f"<a href='{github_help_url}' target='_blank'>GitHub Help</a> to resolve. "
11671167
"(To view the commit's email address, add .patch at the end of this PR page's URL.) "
11681168
"For further assistance with EasyCLA, "
1169-
f"<a href='{support_url}' target='_blank'>please submit a support request ticket</a>."
1169+
f"<a href='{support_url}' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot."
11701170
"</li>"
11711171
)
11721172
else:
@@ -1191,7 +1191,7 @@ def get_comment_body(repository_type, sign_url, signed: List[UserCommitSummary],
11911191
f"select the appropriate company from the list, then confirm "
11921192
f"your affiliation on the page that appears. "
11931193
f"For further assistance with EasyCLA, "
1194-
f"<a href='{support_url}' target='_blank'>please submit a support request ticket</a>."
1194+
f"<a href='{support_url}' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot."
11951195
"</li>"
11961196
)
11971197
else:
@@ -1204,7 +1204,7 @@ def get_comment_body(repository_type, sign_url, signed: List[UserCommitSummary],
12041204
"is not authorized under a signed CLA. "
12051205
f"<a href='{sign_url}' target='_blank'>Please click here to be authorized</a>. "
12061206
f"For further assistance with EasyCLA, "
1207-
f"<a href='{support_url}' target='_blank'>please submit a support request ticket</a>."
1207+
f"<a href='{support_url}' target='_blank'>please visit our EasyCLA portal</a> and chat with our support bot."
12081208
"</li>"
12091209
)
12101210

0 commit comments

Comments
 (0)