Skip to content

Unicron fix 4813#4814

Closed
lukaszgryglicki wants to merge 2 commits intomainfrom
unicron-fix-4813
Closed

Unicron fix 4813#4814
lukaszgryglicki wants to merge 2 commits intomainfrom
unicron-fix-4813

Conversation

@lukaszgryglicki
Copy link
Copy Markdown
Member

This fixes #4813 - but needs to restore to latest deployed branch which is v2.2.6 and only then adds a single fix in cla-backend-go/github/github_repository.go file.

cc @mlehotskylf @jarias-lfx @ahmedomosanya

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
@lukaszgryglicki lukaszgryglicki self-assigned this Oct 8, 2025
Copilot AI review requested due to automatic review settings October 8, 2025 05:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unicron-fix-4813

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a fix for issue #4813 by reverting caching and GraphQL optimizations that were causing issues, restoring to a simpler v2.2.6 baseline approach. The changes revert to the original GitHub API commit fetching logic, simplify comment body normalization, and remove complex caching mechanisms to improve reliability.

  • Reverts GraphQL-based commit fetching to the original REST API approach
  • Removes complex caching mechanisms that were causing inconsistencies
  • Simplifies comment body handling and PR status logic
  • Cleans up utility scripts and test files

Reviewed Changes

Copilot reviewed 35 out of 39 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
cla-backend-go/github/github_repository.go Reverts GraphQL optimizations back to REST API calls
cla-backend/cla/models/github_models.py Removes caching and GraphQL features
cla-backend/cla/utils.py Simplifies logging and removes unused function
tests/functional/* Moves test files and fixes path issues
utils/* Removes debug scripts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/functional/cypress/e2e/signatures.cy.ts
Comment thread tests/functional/cypress/e2e/signatures.cy.ts
Comment thread tests/functional/cypress/e2e/signatures.cy.ts
Comment thread tests/functional/cypress/e2e/signatures.cy.ts
Comment thread tests/functional/cypress/e2e/signatures.cy.ts
Comment thread cla-backend-go/github/github_repository.go
Comment thread cla-backend-go/github/github_repository.go
Comment thread cla-backend-go/github/github_repository.go
Comment thread cla-backend/cla/tests/unit/test_github_models.py
Comment thread cla-backend/cla/tests/unit/test_github_models.py
@lukaszgryglicki
Copy link
Copy Markdown
Member Author

All AI feedback is already addressed in #4814 - because all fo that was planned to be a part of the new release, this is why I suggest to approve & merge #4814 instead and do a full new release @mlehotskylf @jarias-lfx .

@lukaszgryglicki lukaszgryglicki deleted the unicron-fix-4813 branch October 8, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants