Unicron fix 4813#4814
Conversation
Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fix for issue #4813 by reverting caching and GraphQL optimizations that were causing issues, restoring to a simpler v2.2.6 baseline approach. The changes revert to the original GitHub API commit fetching logic, simplify comment body normalization, and remove complex caching mechanisms to improve reliability.
- Reverts GraphQL-based commit fetching to the original REST API approach
- Removes complex caching mechanisms that were causing inconsistencies
- Simplifies comment body handling and PR status logic
- Cleans up utility scripts and test files
Reviewed Changes
Copilot reviewed 35 out of 39 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| cla-backend-go/github/github_repository.go | Reverts GraphQL optimizations back to REST API calls |
| cla-backend/cla/models/github_models.py | Removes caching and GraphQL features |
| cla-backend/cla/utils.py | Simplifies logging and removes unused function |
| tests/functional/* | Moves test files and fixes path issues |
| utils/* | Removes debug scripts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
All AI feedback is already addressed in #4814 - because all fo that was planned to be a part of the new release, this is why I suggest to approve & merge #4814 instead and do a full new release @mlehotskylf @jarias-lfx . |
This fixes #4813 - but needs to restore to latest deployed branch which is
v2.2.6and only then adds a single fix incla-backend-go/github/github_repository.gofile.cc @mlehotskylf @jarias-lfx @ahmedomosanya