Unicron implemented rest fallback when graphql fails prod#4828
Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…-fallback-when-graphql-fails Unicron implemente rest fallback when graphql fails
…-fails-prod Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a REST API fallback mechanism when GraphQL operations fail due to permissions issues, providing more robust handling of GitHub API limitations.
- Adds REST fallback logic in both Python and Go implementations when GraphQL fails
- Changes error handling from silent returns to explicit exceptions to trigger fallback
- Implements complete REST-based commit author processing with co-author support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cla-backend/cla/models/github_models.py | Updates GraphQL error handling to raise exceptions and implements comprehensive REST fallback with dual-path processing |
| cla-backend-go/github/github_repository.go | Adds new REST-based commit processing function and integrates fallback mechanism into existing GraphQL workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cc @mlehotskylf @ahmedomosanya @jarias-lfx
Requested
REST APIfallback when GraphQL fails due to permissions.Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot