Skip to content

Unicron implemented rest fallback when graphql fails prod#4828

Merged
lukaszgryglicki merged 5 commits intomainfrom
unicron-implemente-rest-fallback-when-graphql-fails-prod
Oct 16, 2025
Merged

Unicron implemented rest fallback when graphql fails prod#4828
lukaszgryglicki merged 5 commits intomainfrom
unicron-implemente-rest-fallback-when-graphql-fails-prod

Conversation

@lukaszgryglicki
Copy link
Copy Markdown
Member

cc @mlehotskylf @ahmedomosanya @jarias-lfx

Requested REST API fallback when GraphQL fails due to permissions.

Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
…-fallback-when-graphql-fails

Unicron implemente rest fallback when graphql fails
…-fails-prod

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
@lukaszgryglicki lukaszgryglicki self-assigned this Oct 16, 2025
Copilot AI review requested due to automatic review settings October 16, 2025 07:33
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unicron-implemente-rest-fallback-when-graphql-fails-prod

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a REST API fallback mechanism when GraphQL operations fail due to permissions issues, providing more robust handling of GitHub API limitations.

  • Adds REST fallback logic in both Python and Go implementations when GraphQL fails
  • Changes error handling from silent returns to explicit exceptions to trigger fallback
  • Implements complete REST-based commit author processing with co-author support

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
cla-backend/cla/models/github_models.py Updates GraphQL error handling to raise exceptions and implements comprehensive REST fallback with dual-path processing
cla-backend-go/github/github_repository.go Adds new REST-based commit processing function and integrates fallback mechanism into existing GraphQL workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cla-backend/cla/models/github_models.py
Comment thread cla-backend/cla/models/github_models.py
Comment thread cla-backend-go/github/github_repository.go
Comment thread cla-backend-go/github/github_repository.go
@lukaszgryglicki lukaszgryglicki merged commit 4253010 into main Oct 16, 2025
4 of 5 checks passed
@lukaszgryglicki lukaszgryglicki deleted the unicron-implemente-rest-fallback-when-graphql-fails-prod branch October 16, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants