Skip to content

Hotfix issue with PRs from forked repos#4834

Merged
lukaszgryglicki merged 1 commit intomainfrom
unicron-try-to-fix-hanging-easycla
Oct 21, 2025
Merged

Hotfix issue with PRs from forked repos#4834
lukaszgryglicki merged 1 commit intomainfrom
unicron-try-to-fix-hanging-easycla

Conversation

@lukaszgryglicki
Copy link
Copy Markdown
Member

Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
@lukaszgryglicki lukaszgryglicki self-assigned this Oct 21, 2025
Copilot AI review requested due to automatic review settings October 21, 2025 15:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unicron-try-to-fix-hanging-easycla

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where CLA status updates fail for pull requests originating from forked repositories. The fix adds a fallback mechanism to post commit statuses using the PR's commit list when the direct commit object method fails, which commonly occurs with forked repos due to permission differences.

Key Changes:

  • Updated create_commit_status() to accept additional PR and commit SHA parameters for fallback handling
  • Added new create_commit_status_pr_hash() helper function to post statuses via PR commit enumeration
  • Implemented automatic fallback to the new helper when the primary status posting fails

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cla-backend/cla/models/github_models.py
Comment thread cla-backend/cla/models/github_models.py
Comment thread cla-backend/cla/models/github_models.py
@lukaszgryglicki lukaszgryglicki merged commit a7cadb5 into main Oct 21, 2025
3 of 4 checks passed
@lukaszgryglicki lukaszgryglicki deleted the unicron-try-to-fix-hanging-easycla branch October 21, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants