Unicron update e2e test coverage v4 prod#4844
Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…and gitlab-organizations Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…ries Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…-coverage Unicron update e2e test coverage
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…-coverage-v4 Unicron update e2e test coverage v4
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR significantly expands E2E test coverage for the v4 API by adding comprehensive error case testing across multiple endpoints. The changes focus on validating expected failures (authentication errors, malformed parameters, method not allowed, etc.) while also improving test reliability by unskipping previously skipped tests and adding better error handling.
Key changes:
- Added "Expected failures" test suites to validate error scenarios across all API endpoint categories
- Unskipped and fixed numerous previously disabled tests by adding flexible error handling
- Extracted timeout and environment variables as constants for better maintainability
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/functional/cypress/e2e/v4/version.cy.ts | Added unauthenticated access test and comprehensive malformed request validation for version endpoints |
| tests/functional/cypress/e2e/v4/signatures.cy.ts | Unskipped PDF/CSV download tests with flexible error handling; added 401 and parameter validation tests |
| tests/functional/cypress/e2e/v4/projects.cy.ts | Added expected failures suite testing authentication and parameter validation for project endpoints |
| tests/functional/cypress/e2e/v4/metrics.cy.ts | Added comprehensive error testing for metrics endpoints including 401 and malformed parameter scenarios |
| tests/functional/cypress/e2e/v4/health.cy.ts | Added unauthenticated test and malformed request validation for health endpoints |
| tests/functional/cypress/e2e/v4/gitlab-repositories.cy.ts | Added 401 and parameter validation tests for GitLab repository endpoints |
| tests/functional/cypress/e2e/v4/gitlab-organizations.cy.ts | Added expected failures suite for GitLab organization endpoints |
| tests/functional/cypress/e2e/v4/githubActivity.cy.ts | Added error case testing for GitHub webhook activity endpoint |
| tests/functional/cypress/e2e/v4/github-repositories.cy.ts | Fixed test description typo; added comprehensive error testing for GitHub repository endpoints |
| tests/functional/cypress/e2e/v4/github-organizations.cy.ts | Added 401 and parameter validation tests for GitHub organization endpoints |
| tests/functional/cypress/e2e/v4/events.cy.ts | Fixed URL path and updated comment for skipped admin-only endpoint |
| tests/functional/cypress/e2e/v4/docs.cy.ts | Extracted timeout constant for consistency |
| tests/functional/cypress/e2e/v4/company.cy.ts | Unskipped contributor association test with flexible error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot