Skip to content

feat: add shared Open Graph image across crowdfunding site - #240

Merged
emlimlf merged 3 commits into
mainfrom
feat/LFXV2-2855-og-image
Jul 29, 2026
Merged

feat: add shared Open Graph image across crowdfunding site#240
emlimlf merged 3 commits into
mainfrom
feat/LFXV2-2855-og-image

Conversation

@emlimlf

@emlimlf emlimlf commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the broken 485x57 og-image.png with the proper 1200x630 Figma export (design handoff: node 513-3948)
  • Removes the per-initiative logoUrl override on the initiative detail page so every crowdfunding URL shares the same OG image, per the ticket

Test plan

  • pnpm lint — 0 errors
  • pnpm tsc-check — clean
  • Verified og-image.png is 1200x630 and served correctly
  • Verified homepage og:image/twitter:image meta point to the shared image at correct dimensions
  • Verified an initiative page with a logoUrl set no longer overrides the shared image

Fixes LFXV2-2855

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Copilot AI review requested due to automatic review settings July 28, 2026 02:28
@emlimlf
emlimlf requested a review from a team as a code owner July 28, 2026 02:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a consistent Open Graph image across the crowdfunding site.

Changes:

  • Replaces the undersized OG image with a 1200×630 asset.
  • Removes initiative-specific image overrides.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/public/og-image.png Provides the shared social image.
frontend/app/pages/initiatives/[slug]/index.vue Makes initiative pages inherit shared image metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +41 to +42
// ogImage/twitterImage intentionally omitted — inherits the shared site-wide
// image from setup/head.ts (LFXV2-2855: one OG image across the site).
mlehotskylf
mlehotskylf previously approved these changes Jul 28, 2026
Copilot AI review requested due to automatic review settings July 28, 2026 10:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

…ity CVEs

MegaLinter trivy scan flagged CVE-2026-14257 (brace-expansion DoS),
GHSA-r28c-9q8g-f849 (postcss path traversal), and GHSA-r292-9mhp-454m
(tar stack-overflow DoS) in transitive dependencies.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Copilot AI review requested due to automatic review settings July 28, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • frontend/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

frontend/pnpm-workspace.yaml:21

  • The PR description and test plan cover only the shared Open Graph image, but these dependency-policy changes also upgrade tar/PostCSS and rewrite a large part of the lockfile. That unrelated dependency change materially expands the regression and review surface without corresponding rationale or tests. Please move these upgrades to a dedicated dependency/security PR, leaving this feature PR scoped to the OG asset and metadata behavior.
  tar: ">=7.5.21"
  vite: ">=7.3.5"
  postcss: ">=8.5.18"

Comment on lines +22 to +24
"brace-expansion@^1.1.7": ">=5.0.8"
"brace-expansion@^2.0.1": ">=5.0.8"
"brace-expansion@^2.0.2": ">=5.0.8"
@emlimlf
emlimlf merged commit 910336a into main Jul 29, 2026
13 checks passed
@emlimlf
emlimlf deleted the feat/LFXV2-2855-og-image branch July 29, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants