fix(dashboards): show no-data state instead of performing well (#682)

* fix(dashboards): show no-data state instead of performing well

When all campaign data is zero the catch-all action showed
"Performing Well — Maintain current momentum" which is misleading.
Now detects zero email/paid/attribution activity and shows
"No active campaigns detected" under the attention section instead.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): improve no-data message to guide users

Update the no-data description to suggest reaching out to
marketing ops instead of passively waiting for data.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): reword no-data message for campaigns

Emphasize engaging marketing ops for momentum rather than
setting up tracking.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): use neutral card for no-data state

Replace the red attention-section approach with a neutral
blue info card. When all campaign data is zero the drawer
now skips both "Needs Your Attention" and "Performing Well"
and shows a neutral informational card guiding EDs to engage
marketing ops.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): broaden attribution check in hasNoData

Include firstTouchRevenue, lastTouchRevenue, and timeDecayRevenue
in the hasAttributionActivity predicate so channels with non-zero
revenue from any attribution model are correctly detected.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): add a11y attrs and soften no-data copy

Extract dataResolved signal to DRY triple-gate check. Add role=status
and aria-live=polite to no-data card. Remove actionable CTA copy.

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

* fix(dashboards): extract hasNoData to initHasNoData, fix a11y

- Extract inline hasNoData computed to private initHasNoData()
  per component organization rules
- Drop redundant aria-live="polite" (implicit in role="status")
- Use h3 for no-data card title to match heading outline
- Use border-l-blue-600 to match design system -600 shade pattern

LFXV2-1644

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>

---------

Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: mrautela365

apps/lfx-one/src/app/modules/dashboards/executive-director/components/email-ctr-drawer/email-ctr-drawer.component.html

@@ -99,6 +99,21 @@ <h3 class="text-sm font-semibold text-green-700">Performing Well</h3>
         </div>
       }
 
+      @if (hasNoData()) {
+        <div
+          class="flex flex-col rounded-lg border border-gray-200 border-l-4 border-l-blue-600 bg-white overflow-hidden"
+          role="status"
+          data-testid="email-ctr-drawer-no-data">
+          <div class="flex items-start gap-4 px-4 py-4">
+            <i class="fa-light fa-circle-info text-blue-500 mt-0.5" aria-hidden="true"></i>
+            <div class="flex flex-col gap-1 flex-1 min-w-0">
+              <h3 class="text-sm font-semibold text-gray-900">No active campaigns detected</h3>
+              <p class="text-sm text-gray-500">No email, paid, or attribution activity is currently available for this foundation</p>
+            </div>
+          </div>
+        </div>
+      }
+
       @if (attributionData().channels.length > 0) {
         <div class="flex flex-col gap-5" data-testid="email-ctr-drawer-attribution-section">
           <div class="flex items-center gap-2">

apps/lfx-one/src/app/modules/dashboards/executive-director/components/email-ctr-drawer/email-ctr-drawer.component.ts

@@ -54,6 +54,12 @@ export class EmailCtrDrawerComponent {
   protected readonly performingActions: Signal<MarketingRecommendedAction[]> = computed(() => this.split().performingActions);
 
   protected readonly performingInsights: Signal<MarketingKeyInsight[]> = computed(() => this.split().performingInsights);
+
+  // True once all three data sources have resolved (not still loading)
+  private readonly dataResolved: Signal<boolean> = computed(() => !this.drawerLoading() && this.paidDataResolved() && this.attributionDataResolved());
+
+  protected readonly hasNoData: Signal<boolean> = this.initHasNoData();
+
   protected readonly expandedTypes = signal<Set<string>>(new Set());
 
   protected readonly emailTotalSends: Signal<string> = computed(() => {
@@ -212,6 +218,23 @@ export class EmailCtrDrawerComponent {
     return channel.sessions > 0 ? `$${(channel.linearRevenue / channel.sessions).toFixed(2)}` : '—';
   }
 
+  private initHasNoData(): Signal<boolean> {
+    return computed(() => {
+      if (!this.dataResolved()) {
+        return false;
+      }
+      const email = this.drawerData();
+      const paid = this.paidData();
+      const attribution = this.attributionData();
+      const hasEmailActivity = email.currentCtr > 0 || email.monthlySends.some((s) => s > 0);
+      const hasPaidActivity = paid.totalReach > 0 || paid.totalSpend > 0;
+      const hasAttributionActivity =
+        attribution.channels.length > 0 &&
+        attribution.channels.some((c) => c.sessions > 0 || c.linearRevenue > 0 || c.firstTouchRevenue > 0 || c.lastTouchRevenue > 0 || c.timeDecayRevenue > 0);
+      return !hasEmailActivity && !hasPaidActivity && !hasAttributionActivity;
+    });
+  }
+
   private initDrawerData(): Signal<EmailCtrResponse> {
     const defaultValue: EmailCtrResponse = {
       currentCtr: 0,
@@ -255,7 +278,7 @@ export class EmailCtrDrawerComponent {
     return computed(() => {
       // Gate on all three data sources having resolved — avoid misleading
       // "Maintain current momentum" while paid/attribution are still in-flight.
-      if (this.drawerLoading() || !this.paidDataResolved() || !this.attributionDataResolved()) {
+      if (!this.dataResolved()) {
         return [];
       }
 
@@ -392,7 +415,7 @@ export class EmailCtrDrawerComponent {
       // Combine — 1 per section, max 3
       const actions = [...attrActions.slice(0, 1), ...paidActions.slice(0, 1), ...emailActions.slice(0, 1)];
 
-      if (actions.length === 0) {
+      if (actions.length === 0 && !this.hasNoData()) {
         actions.push({
           title: 'Maintain current momentum',
           description: 'All channels performing well — continue current strategy and monitor for shifts',
@@ -408,7 +431,7 @@ export class EmailCtrDrawerComponent {
   private initKeyInsights(): Signal<MarketingKeyInsight[]> {
     return computed(() => {
       // Gate on all three data sources — same rationale as initRecommendedActions.
-      if (this.drawerLoading() || !this.paidDataResolved() || !this.attributionDataResolved()) {
+      if (!this.dataResolved()) {
         return [];
       }