fix(navigation): keep contributor with board-member role (#613)

Author: bramwelt

apps/lfx-one/src/server/services/navigation.service.ts

@@ -101,8 +101,7 @@ export class NavigationService {
     // other lenses (e.g., Me → Open) doesn't get overridden by the default picker.
     if (selectedUid && !pageToken) {
       const alreadyIncluded = accumulated.some((item) => item.uid === selectedUid);
-      const allowedByPersona = !eligibleUids || eligibleUids.has(selectedUid);
-      if (!alreadyIncluded && allowedByPersona) {
+      if (!alreadyIncluded) {
         const selectedItem = await this.fetchSelectedItem(req, lens, selectedUid);
         if (selectedItem) {
           accumulated.unshift(selectedItem);

apps/lfx-one/src/server/services/persona-detection.service.ts

@@ -372,8 +372,10 @@ export class PersonaDetectionService {
       personas.add('contributor');
     }
 
-    // Drop contributor when a more specific role is present.
-    if (personas.size > 1 && personas.has('contributor')) {
+    // Drop contributor only when maintainer is present — the true upgrade
+    // of the same domain. Board-member / executive-director are orthogonal
+    // foundation roles and must not cause contributor to be dropped.
+    if (personas.has('contributor') && personas.has('maintainer')) {
       personas.delete('contributor');
     }