fix(dx): address PR #672 iteration 3 review feedback

manishdixitlfx · manishdixitlfx · commit ee7e63f22c8b · 2026-05-11T13:48:55.000-07:00
Address review comments from @copilot-pull-request-reviewer: - Step 4 hard checks: replaced the manual prose Signed-off-by check with a single combined verification command that asserts both GPG signature status (`%G?`) and trailer presence per commit via `git log --format='%G? %(trailers:key=Signed-off-by,valueonly...)'` — fail-fast block is now fully actionable rather than partly manual (per @copilot-pull-request-reviewer on line 75) - Step 6 gh pr create: dropped the branch-name fallback for PR title and clarified the title must be `type(scope): description`, lowercase, no JIRA ticket. If the first commit subject doesn't satisfy that, command asks user for a valid title. Prevents PR-title-lint CI failures from branch-name fallbacks like `feat/LFXV2-1697` (per @copilot-pull-request-reviewer on line 124) - Step 6 PR-body checklist: `yarn lint` -> `yarn lint:check`, added `yarn format:check` line, so checklist labels now match the gates actually run in Step 3 (per @copilot-pull-request-reviewer on line 112) Item 4 (false positive on GPG mandate, line 50) is being handled by companion PR #674 which documents the GPG-enforcement policy in CLAUDE.md and .claude/rules/commit-workflow.md. Item 5 (draft-mode contradiction at line 13) deferred pending user direction on whether to implement --draft end-to-end or remove the draft references from $ARGUMENTS interpretation. Resolves 3 of 5 review threads; 1 reply-only (false positive); 1 deferred. Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>
diff --git a/.claude/commands/lfx-pr.md b/.claude/commands/lfx-pr.md
@@ -72,7 +72,13 @@ Run these hard policy checks first (fail-fast):
 yarn commitlint --from origin/main --to HEAD
 ```
 
-Also verify every commit in `origin/main..HEAD` has a `Signed-off-by:` trailer **and** a valid GPG signature (`git log --format='%G?' origin/main..HEAD` — every line must be `G`). If any hard policy check fails, stop and report.
+Also verify every commit in `origin/main..HEAD` has both a `Signed-off-by:` trailer and a valid GPG signature:
+
+```bash
+git log --format='%G? %(trailers:key=Signed-off-by,valueonly,separator=%x20) %h %s' origin/main..HEAD
+```
+
+Each line must start with `G` (good GPG signature) **and** have a non-empty `Signed-off-by` value before the SHA. If any commit fails either check, stop and report.
 
 Then run advisory review on:
 
@@ -109,7 +115,8 @@ PR body template:
 - Screenshots placeholder
 - Pre-merge checklist (rendered into the PR body):
   - [x] `yarn check-types` clean
-  - [x] `yarn lint` clean
+  - [x] `yarn lint:check` clean
+  - [x] `yarn format:check` clean
   - [x] `yarn test` passing
   - [x] `yarn build` passing (SSR safe)
   - [x] DCO sign-off (`--signoff`) and GPG signed (`-S`) on every commit
@@ -120,7 +127,11 @@ PR body template:
 
 - Footer: 🤖 Drafted via /lfx-pr — Claude Code
 
-gh pr create --base main --title "<first commit subject or branch name>" --body-file <body>
+Derive the PR title from the first commit subject. It must be a valid conventional-commit title: `type(scope): description`, all lowercase, no JIRA ticket. If the first commit subject doesn't satisfy that format (e.g., the branch only has merge commits, or the subject violates the rules), ask the user for a valid title before invoking `gh`.
+
+```bash
+gh pr create --base main --title "<conventional-commit title>" --body-file <body>
+```
 
 If gh unavailable, print branch URL + body for manual open.
 
