fix(campaigns): correct germany/uk linkedin geo urns#1128
Conversation
LINKEDIN_GEO_RESOLVE_MAP mapped germany -> urn:li:geo:101165590 and united kingdom -> urn:li:geo:106693272. Verified against LinkedIn's geo reference, 101165590 is the United Kingdom and 106693272 is Switzerland, so germany-targeted paid campaigns resolved to the UK and UK campaigns to Switzerland. Correct germany to 101282230 and the United Kingdom to 101165590. This is the shared-constant source of truth for the same defect already fixed in the lfx-v2-campaign-service Go client (LINKEDIN geoResolveMap); fixing it here keeps the TS client and Go port aligned. Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 3fc7861. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe LinkedIn geo-target resolution map updates the URNs for Germany and the United Kingdom without changing its exports, types, or structure. ChangesLinkedIn geo updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
There was a problem hiding this comment.
Pull request overview
Corrects LinkedIn campaign geo targeting for Germany and the United Kingdom.
Changes:
- Maps Germany to
urn:li:geo:101282230. - Maps the United Kingdom to
urn:li:geo:101165590.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Closing — this session's scope is campaign-service (Go). The Go copy of this geo map is already fixed in campaign-service PR #22 (internal/platform/linkedin geoResolveMap). The TS |
Summary
LINKEDIN_GEO_RESOLVE_MAPmapped germany →urn:li:geo:101165590and united kingdom →urn:li:geo:106693272. Verified against LinkedIn's geo reference:101282230101165590106693272So as written, germany-targeted paid campaigns resolved to the UK, and UK campaigns to Switzerland. This corrects germany →
101282230and united kingdom →101165590.Scope
Two string-literal values in the shared constant. Consumers (
linkedin-ads.service.ts,implementation-tab.component.ts) reference the map by.urnand pick up the correction automatically — no other changes needed.Related
This is the shared-constant source of truth for the same defect already fixed in the
lfx-v2-campaign-serviceGo client (internal/platform/linkedingeoResolveMap, PR #22). Fixing it here keeps the TS client and Go port aligned. Tracked under LFXV2-2665.Verification
yarn lint:check,yarn check-types,yarn buildpass (pre-commit hook)