Skip to content

fix(campaigns): correct germany/uk linkedin geo urns#1128

Closed
mrautela365 wants to merge 1 commit into
mainfrom
fix/LFXV2-2665-linkedin-geo-urns
Closed

fix(campaigns): correct germany/uk linkedin geo urns#1128
mrautela365 wants to merge 1 commit into
mainfrom
fix/LFXV2-2665-linkedin-geo-urns

Conversation

@mrautela365

Copy link
Copy Markdown
Contributor

Summary

LINKEDIN_GEO_RESOLVE_MAP mapped germany → urn:li:geo:101165590 and united kingdom → urn:li:geo:106693272. Verified against LinkedIn's geo reference:

URN Actual country
101282230 Germany
101165590 United Kingdom
106693272 Switzerland

So as written, germany-targeted paid campaigns resolved to the UK, and UK campaigns to Switzerland. This corrects germany → 101282230 and united kingdom → 101165590.

Scope

Two string-literal values in the shared constant. Consumers (linkedin-ads.service.ts, implementation-tab.component.ts) reference the map by .urn and pick up the correction automatically — no other changes needed.

Related

This is the shared-constant source of truth for the same defect already fixed in the lfx-v2-campaign-service Go client (internal/platform/linkedin geoResolveMap, PR #22). Fixing it here keeps the TS client and Go port aligned. Tracked under LFXV2-2665.

Verification

  • yarn lint:check, yarn check-types, yarn build pass (pre-commit hook)
  • License header check passes
  • LinkedIn geo URNs verified against LinkedIn's geography reference

LINKEDIN_GEO_RESOLVE_MAP mapped germany -> urn:li:geo:101165590 and united
kingdom -> urn:li:geo:106693272. Verified against LinkedIn's geo reference,
101165590 is the United Kingdom and 106693272 is Switzerland, so germany-targeted
paid campaigns resolved to the UK and UK campaigns to Switzerland. Correct germany
to 101282230 and the United Kingdom to 101165590.

This is the shared-constant source of truth for the same defect already fixed in
the lfx-v2-campaign-service Go client (LINKEDIN geoResolveMap); fixing it here
keeps the TS client and Go port aligned.

Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
@mrautela365
mrautela365 requested a review from a team as a code owner July 18, 2026 05:45
Copilot AI review requested due to automatic review settings July 18, 2026 05:45
@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Wrong geo targeting directly affects paid LinkedIn campaign delivery and spend; the fix is low-touch but corrects a live targeting bug.

Overview
Fixes swapped LinkedIn geography URNs in LINKEDIN_GEO_RESOLVE_MAP so Germany and United Kingdom resolve to the correct countries instead of the UK and Switzerland respectively.

germany now uses urn:li:geo:101282230 and united kingdom uses urn:li:geo:101165590. Only those two URN strings change in the shared constant; linkedin-ads.service.ts geo resolution and the implementation tab geo picker pick up the fix via the map.

Reviewed by Cursor Bugbot for commit 3fc7861. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dcc27d66-df67-4983-8610-0b98d43e884e

📥 Commits

Reviewing files that changed from the base of the PR and between 3479125 and 3fc7861.

📒 Files selected for processing (1)
  • packages/shared/src/constants/campaign.constants.ts

Walkthrough

The LinkedIn geo-target resolution map updates the URNs for Germany and the United Kingdom without changing its exports, types, or structure.

Changes

LinkedIn geo updates

Layer / File(s) Summary
Update location geo identifiers
packages/shared/src/constants/campaign.constants.ts
The map now uses new LinkedIn geo identifiers for Germany and the United Kingdom.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the core change: correcting LinkedIn geo URNs for Germany and the UK.
Description check ✅ Passed The description matches the change, explains the URN corrections, and references the affected shared map and consumers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/LFXV2-2665-linkedin-geo-urns

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects LinkedIn campaign geo targeting for Germany and the United Kingdom.

Changes:

  • Maps Germany to urn:li:geo:101282230.
  • Maps the United Kingdom to urn:li:geo:101165590.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrautela365

Copy link
Copy Markdown
Contributor Author

Closing — this session's scope is campaign-service (Go). The Go copy of this geo map is already fixed in campaign-service PR #22 (internal/platform/linkedin geoResolveMap). The TS LINKEDIN_GEO_RESOLVE_MAP here is on the code slated for deletion in the Phase 4 cutover (Express linkedin-ads.service → thin proxy calling campaign-service), so this interim UI-repo fix is being deferred to be handled with that UI work rather than as a standalone cross-repo PR from this lane.

@mrautela365
mrautela365 deleted the fix/LFXV2-2665-linkedin-geo-urns branch July 18, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants