fix(review): address PR #25 review feedback

Address review comment from copilot-pull-request-reviewer[bot]:

- messaging_repository.go: flatten ctx-deadline/timeout guard so that
  a caller-supplied timeout <= 0 is also caught. Previously, the nested
  `remaining < timeout` condition was false when timeout was negative
  and remaining was positive, silently passing an invalid duration to
  RequestMsg. Now: always clamp to ctx deadline when shorter, then a
  single `timeout <= 0` guard short-circuits with context.DeadlineExceeded
  before reaching NATS.

Resolves 1 review thread.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Issue: LFXV2-1743
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

Author: bramwelt

internal/infrastructure/messaging/messaging_repository.go

@@ -116,19 +116,19 @@ func (r *messagingRepository) Request(ctx context.Context, subject string, data
 		return nil, constants.ErrNATSConnNotInit
 	}
 
-	// Use the shorter of the explicit timeout and any deadline already on ctx.
-	// If the deadline is already past, short-circuit rather than passing a
-	// negative duration to RequestMsg.
+	// Clamp timeout to the ctx deadline if it is shorter.
 	if deadline, ok := ctx.Deadline(); ok {
 		if remaining := time.Until(deadline); remaining < timeout {
-			if remaining <= 0 {
-				span.RecordError(context.DeadlineExceeded)
-				span.SetStatus(codes.Error, context.DeadlineExceeded.Error())
-				return nil, context.DeadlineExceeded
-			}
 			timeout = remaining
 		}
 	}
+	// Short-circuit if timeout is zero or negative — either the caller passed
+	// an invalid duration or the ctx deadline was already past.
+	if timeout <= 0 {
+		span.RecordError(context.DeadlineExceeded)
+		span.SetStatus(codes.Error, context.DeadlineExceeded.Error())
+		return nil, context.DeadlineExceeded
+	}
 
 	natsMsg := nats.NewMsg(subject)
 	natsMsg.Data = data