Publish 0.0.0-development Helm chart on main merges - #60
Conversation
Add release-helm-chart job to ko-build-main.yaml that publishes a 0.0.0-development Helm chart to GHCR on every push to main, mirroring the tagged release workflow but without cosign signing or SLSA provenance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-2482 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe main build workflow gains a workflow-level ChangesHelm Chart Release Job
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the main-branch build workflow to also publish an OCI Helm chart tagged as 0.0.0-development to GHCR on every push to main, aligning the “dev” publishing path with the tagged release workflow’s chart publishing behavior (minus signing/provenance).
Changes:
- Adds a
release-helm-chartjob to publish a development Helm chart to GHCR after the image publish job succeeds. - Adds a workflow-level
HELM_VERSIONenvironment variable for consistent Helm tooling. - Updates workflow token permissions to support publishing to GHCR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ko-build-main.yaml:
- Around line 15-17: Remove the unnecessary `packages: write` permission from
the workflow-level permissions block since both the `publish` and
`release-helm-chart` jobs already declare this permission at job scope,
following the principle of least privilege. Additionally, locate the checkout
action in the workflow and add the `persist-credentials: false` configuration to
disable credential persistence, as this workflow does not require authenticated
Git operations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2aebba1f-a469-48e8-a039-219ff99877f5
📒 Files selected for processing (1)
.github/workflows/ko-build-main.yaml
- Remove top-level `packages: write` permission (each job already declares it at job level) - Add `persist-credentials: false` to release-helm-chart checkout step for security hardening 🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-2482 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Review feedback addressed (1e17a12)Fixed:
Not changed:
|
Review Feedback AddressedCommit: 1e17a12 Changes Made
No Change Needed
Threads Resolved3 of 3 unresolved threads addressed. |
Summary
release-helm-chartjob toko-build-main.yamlthat publishes a0.0.0-developmentHelm chart to GHCR on every push to mainHELM_VERSION: v3.18.4env var andpackages: writepermission to match the tag workflowTest plan
ghcr.io/linuxfoundation/lfx-v2-query-service/chart/lfx-v2-query-service:0.0.0-developmentrelease-helm-chartjob runs afterpublishjob succeedsIssue: LFXV2-2482
🤖 Generated with Claude Code