Add deployment annotation for Backstage ingestion#28
Conversation
Signed-off-by: Antonia Gaete <agaete@linuxfoundation.org>
There was a problem hiding this comment.
Pull request overview
Adds metadata intended to support Spotify Backstage Kubernetes ingestion/discovery for the lfx-v2-voting-service Helm chart.
Changes:
- Add
app.kubernetes.io/nameto the Deployment’s top-levelmetadata.labels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| namespace: {{ .Values.lfx.namespace }} | ||
| labels: | ||
| app: {{ .Chart.Name }} | ||
| app.kubernetes.io/name: {{ .Chart.Name }} |
There was a problem hiding this comment.
PR title/description mention adding a deployment annotation for Backstage discovery, but the change adds a Kubernetes label (app.kubernetes.io/name) instead of an annotation. If Backstage ingestion is expecting a specific annotation key/value, this won’t satisfy the stated goal; either update the PR description/title or add the required metadata.annotations entry in the Deployment template.
| labels: | ||
| app: {{ .Chart.Name }} | ||
| app.kubernetes.io/name: {{ .Chart.Name }} |
There was a problem hiding this comment.
app.kubernetes.io/name is being added only to the Deployment object’s metadata.labels. Labels there do not propagate to ReplicaSets/Pods; if this label is meant for discovery/selection, it should also be added under spec.template.metadata.labels (and possibly other related resources) so the running Pods carry it.
Signed-off-by: Antonia Gaete <agaete@linuxfoundation.org>
Signed-off-by: Antonia Gaete <agaete@linuxfoundation.org>
Spotify Backstage can pull kubernetes data from components using deployment annotations. This service is missing the name annotation needed to discover it.