[simple-system-monitor@ariel] Remove desklet#1837
Closed
fredcw wants to merge 1 commit intolinuxmint:masterfrom
Closed
[simple-system-monitor@ariel] Remove desklet#1837fredcw wants to merge 1 commit intolinuxmint:masterfrom
fredcw wants to merge 1 commit intolinuxmint:masterfrom
Conversation
remove due to a number of issues: requires user to enter "Path to CPU temperature directory" which is not user friendly at all. Same for GPU temp. Has dependancy libgtop, which shouldn't be needed for what this desklet does. Has a few bugs: text not fitting width of desklet properly. Spams ~./xession-errors, if temp path is wrong. Duplicates timers on setting changes (memory leak). Doesn't remove timers on removal (continues to spam ~/.xseesion-errors), CPU usage is sometimes "NaN" bug.
Member
|
This is still actively maintained and functional. It could use some improvements but it is not at the bar for deletion. I can set myself as the maintainer if needed. |
Contributor
Author
|
@rcalixte Ok, or set the author to none, up to you. I'll create a PR to fix the timer issues. |
Contributor
Author
Actually, I don't really have time. I asked gemini to fix the issues and it changed almost every line xD |
Member
|
Thanks. I don't mind implementing the fixes in a traditional manner. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove desklet due to a number of issues:
Requires user to enter "Path to CPU temperature directory" which is not user friendly at all. Same for GPU temp.
Has dependency libgtop, which shouldn't be needed for what this desklet does.
Has a few bugs: text not fitting width of desklet properly. Spams ~./xession-errors, if temp or GPU path is wrong. Duplicates timers on setting changes (memory leak). Doesn't remove timers on removal (continues to spam ~/.xseesion-errors), CPU usage is sometimes "NaN" bug (also reported on spices page).
This is also abandoned by it's author #279 (comment)
Basically, it needs a complete rewrite if it's to be worth keeping. Lack of user friendliness is the main issue.
Also, #1834 is a good replacement.