stoic-quote@orion: add more quotes#1848
Open
WanderingBread0 wants to merge 1 commit into
Open
Conversation
Expand the curated corpus from 63 to 122 quotes and broaden the roster of authors. Bumps to v0.2.0. Content: - 59 new quotes added across both existing and new authors. - New authors: Heraclitus (4), Diogenes the Cynic (4), Antisthenes (1), Cato the Younger (1), Hierocles (1) — all proto-Stoic or Stoic exemplars whose work informed or paralleled the seven already represented. - Each text/author/source is wrapped in _() so xgettext extracts every string and translators can localize the full data set. - metadata.json description updated to reflect the broader roster. Code cleanup: - Timer callback in _scheduleNextRefresh now returns GLib.SOURCE_REMOVE (named constant) instead of the boolean false, per the contributor guidelines. Translations: - po/stoic-quote@orion.pot regenerated via cinnamon-spices-makepot (132 -> 232 unique msgids). - po/es.po and po/hu.po merged via msgmerge --previous so existing translations are preserved; new strings appear as untranslated, and near-matches (e.g. new book/chapter citations that resemble existing ones) are marked fuzzy with the previous translation as a starting point for the translator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the curated corpus from 63 to 122 quotes and broadens the roster of authors. Version bumped to 0.2.0.
New content
text/author/sourceis wrapped in_()so xgettext extracts them and translators can localize the whole data set.metadata.jsondescription updated to reflect the broader roster.Code cleanup
_scheduleNextRefreshreturnsGLib.SOURCE_REMOVE(named constant) instead offalse, per the contributor guidelines.Translations
po/stoic-quote@orion.potregenerated withcinnamon-spices-makepot— 132 → 232 unique msgids.po/es.po(from stoic-quote@orion - Add Spanish translation #1835) andpo/hu.po(from Hungarian translation update for Cinnamon Desklets #1843) merged viamsgmerge --previous:#, fuzzywith the previous translation seeded as a starting point — so the next pass for translators is a quick verify, not a rewrite.Test plan
node --checkon desklet.js and quotes.js)stoic-quote@orion/