screenshot: Allow disabling the flash.

Adds a Preference to disable the 'flash' effect when taking a
screenshot.

Remove some unused code.

ref: https://github.com/orgs/linuxmint/discussions/219

Author: mtwebster

data/org.cinnamon.gschema.xml

@@ -1046,6 +1046,12 @@
       <description>When enabled, a copy of every screenshot that is saved to a file is also placed on the clipboard.</description>
     </key>
 
+    <key name="use-flash" type="b">
+      <default>true</default>
+      <summary>Use a flash</summary>
+      <description>When enabled, a brief flash is shown over the captured area after taking a screenshot.</description>
+    </key>
+
   </schema>
 
 </schemalist>

files/usr/share/cinnamon/cinnamon-screenshot/backends/base.py

@@ -14,9 +14,6 @@ def screenshot_window_by_id(self, window_id, include_pointer, include_shadow, on
     def screenshot_area(self, x, y, w, h, include_pointer, on_done, copy_to_clipboard=False):
         on_done(None)
 
-    def flash_area(self, x, y, w, h):
-        pass
-
     def select_area(self, on_done):
         on_done(None)
 

files/usr/share/cinnamon/cinnamon-screenshot/backends/cinnamon.py

@@ -91,10 +91,6 @@ def screenshot_area(self, x, y, w, h, include_pointer, on_done, copy_to_clipboar
                    GLib.Variant('(iiiibsb)', (x, y, w, h, include_pointer, path, copy_to_clipboard)),
                    lambda result: self._deliver_image(path, result, on_done))
 
-    def flash_area(self, x, y, w, h):
-        self._proxy.call('FlashArea', GLib.Variant('(iiii)', (x, y, w, h)),
-                         Gio.DBusCallFlags.NONE, -1, None, None)
-
     def select_area(self, on_done):
         self._call('SelectArea', None,
                    lambda result: on_done(tuple(result) if result else None))

files/usr/share/cinnamon/cinnamon-screenshot/prefs.py

@@ -14,6 +14,7 @@
 LAUNCH_FILE_MANAGER_KEY = 'launch-file-manager-after-save'
 AUTOSAVE_TO_FILE_KEY = 'autosave-to-file'
 AUTOSAVE_TO_CLIPBOARD_KEY = 'autosave-to-clipboard'
+USE_FLASH_KEY = 'use-flash'
 
 settings = Gio.Settings.new(SCHEMA_ID)
 if not settings.get_string(SAVE_DIRECTORY_KEY):
@@ -126,6 +127,10 @@ def __init__(self, parent):
             _('Copy to clipboard when saving'),
             SCHEMA_ID, AUTOSAVE_TO_CLIPBOARD_KEY,
         ))
+        section_behavior.add_row(GSettingsSwitch(
+            _('Use a flash'),
+            SCHEMA_ID, USE_FLASH_KEY,
+        ))
 
         self.window.show_all()
 

files/usr/share/cinnamon/cinnamon-screenshot/screenshot_backend.py

@@ -41,9 +41,6 @@ def screenshot_window_by_id(self, window_id, include_pointer, include_shadow, on
     def screenshot_area(self, x, y, w, h, include_pointer, on_done, copy_to_clipboard=False):
         self._active().screenshot_area(x, y, w, h, include_pointer, on_done, copy_to_clipboard=copy_to_clipboard)
 
-    def flash_area(self, x, y, w, h):
-        self._active().flash_area(x, y, w, h)
-
     def select_area(self, on_done):
         self._active().select_area(on_done)
 

js/ui/screenshot.js

@@ -130,12 +130,6 @@ const ScreenshotIface =
                 <arg type="b" direction="out" name="success"/> \
                 <arg type="s" direction="out" name="filename_used"/> \
             </method> \
-            <method name="FlashArea"> \
-                <arg type="i" direction="in" name="x"/> \
-                <arg type="i" direction="in" name="y"/> \
-                <arg type="i" direction="in" name="width"/> \
-                <arg type="i" direction="in" name="height"/> \
-            </method> \
             <method name="SelectArea"> \
               <arg type="i" direction="out" name="x"/> \
               <arg type="i" direction="out" name="y"/> \
@@ -164,10 +158,12 @@ var ScreenshotService = class ScreenshotService {
         this._dbusImpl.export(Gio.DBus.session, '/org/cinnamon/Screenshot');
 
         Gio.DBus.session.own_name('org.cinnamon.Screenshot', Gio.BusNameOwnerFlags.REPLACE, null, null);
+
+        this._settings = new Gio.Settings({ schema_id: 'org.cinnamon.screenshot' });
     }
 
     _onScreenshotComplete (obj, success, area, filename, invocation=null) {
-        if (success) {
+        if (success && this._settings.get_boolean('use-flash')) {
             let flashspot = new Flashspot.Flashspot(area);
             flashspot.fire();
         }
@@ -291,18 +287,6 @@ var ScreenshotService = class ScreenshotService {
         }
     }
 
-    FlashAreaAsync(params, invocation) {
-        let [x, y, width, height] = params;
-
-        let flashspot = new Flashspot.Flashspot({
-            x: x * global.ui_scale,
-            y: y * global.ui_scale,
-            width: width * global.ui_scale,
-            height: height * global.ui_scale
-        });
-        flashspot.fire();
-        invocation.return_value(null);
-    }
 }
 
 class SelectArea {