expo/overview: Refactor to Use newer/gobject class styles, easing.#13700
Open
mtwebster wants to merge 8 commits intolinuxmint:masterfrom
Open
expo/overview: Refactor to Use newer/gobject class styles, easing.#13700mtwebster wants to merge 8 commits intolinuxmint:masterfrom
mtwebster wants to merge 8 commits intolinuxmint:masterfrom
Conversation
Member
mtwebster
commented
Apr 9, 2026
mtwebster
commented
- Stop using Lang.bind().
- Use actor easing instead of tweening.
- Use actor/widget subclasses instead of this.actor/GenericContainers.
- Use connectObject/disconnectObject for signal handling.
- Use GLib instead of Mainloop.
- Stop using Lang.bind(). - Use actor easing instead of tweening. - Use actor/widget subclasses instead of this.actor/GenericContainers. - Use connectObject/disconnectObject for signal handling. - Use GLib instead of Mainloop.
mtwebster
force-pushed
the
expo-overview-actor-classes
branch
from
1ff4cd5 to
f12d5ba
Compare
timeline for a delay.
JosephMcc
reviewed
Apr 10, 2026
| this.actor.connect('scroll-event', this.onScrollEvent); | ||
|
|
||
| this.connect('scroll-event', this.onScrollEvent.bind(this)); |
Contributor
There was a problem hiding this comment.
Since all this stuff is now objects, do you need to do this? Can't you just use all the parents vfuncs instead of the signal connections?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.