Skip to content

add initial tested version#1

Merged
thelamer merged 2 commits into
masterfrom
initial
Jun 6, 2025
Merged

add initial tested version#1
thelamer merged 2 commits into
masterfrom
initial

Conversation

@thelamer

@thelamer thelamer commented Jun 6, 2025

Copy link
Copy Markdown
Member

No Cstate for this one yet, just want it built and available publically, will do a blog post about a couple new images.

@thelamer thelamer requested a review from a team June 6, 2025 15:13
@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/brave/1.79.119-pkg-none-dev-eb42e01cc2a773f4fd4a1400ac0d4adb06ffada1-pr-1/index.html
https://ci-tests.linuxserver.io/lspipepr/brave/1.79.119-pkg-none-dev-eb42e01cc2a773f4fd4a1400ac0d4adb06ffada1-pr-1/shellcheck-result.xml

Tag Passed
amd64-1.79.119-pkg-none-dev-eb42e01cc2a773f4fd4a1400ac0d4adb06ffada1-pr-1
arm64v8-1.79.119-pkg-none-dev-eb42e01cc2a773f4fd4a1400ac0d4adb06ffada1-pr-1

@thespad

thespad commented Jun 6, 2025

Copy link
Copy Markdown
Member

Looks like the browser crashed in the CI tests, anything to worry about?

@thelamer

thelamer commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

Looks like the browser crashed in the CI tests, anything to worry about?

We need the testers to pass shm-size for any of this stuff to work all the time. Chromium landing is much less involved than brave, you get the same thing with Opera.

@thespad

thespad commented Jun 6, 2025

Copy link
Copy Markdown
Member

Can you add

# syntax=docker/dockerfile:1

To the top of the Dockerfiles and

printf "Linuxserver.io version: ${VERSION}\nBuild-date: ${BUILD_DATE}" > /build_version

To the end of their RUN. It lets the init print the build version & date to the container logs so we don't have to rely on the user to give us accurate information.

@thelamer

thelamer commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

Can you add

# syntax=docker/dockerfile:1

To the top of the Dockerfiles and

printf "Linuxserver.io version: ${VERSION}\nBuild-date: ${BUILD_DATE}" > /build_version

To the end of their RUN. It lets the init print the build version & date to the container logs so we don't have to rely on the user to give us accurate information.

Added to retroarch and brave

@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/brave/1.79.119-pkg-none-dev-c4aade091dd87e5e8cd4ead7922420bc7ce7db8f-pr-1/index.html
https://ci-tests.linuxserver.io/lspipepr/brave/1.79.119-pkg-none-dev-c4aade091dd87e5e8cd4ead7922420bc7ce7db8f-pr-1/shellcheck-result.xml

Tag Passed
amd64-1.79.119-pkg-none-dev-c4aade091dd87e5e8cd4ead7922420bc7ce7db8f-pr-1
arm64v8-1.79.119-pkg-none-dev-c4aade091dd87e5e8cd4ead7922420bc7ce7db8f-pr-1

@LinuxServer-CI LinuxServer-CI moved this to PRs Approved in Issue & PR Tracker Jun 6, 2025
@thelamer thelamer merged commit 6d8b81d into master Jun 6, 2025
3 checks passed
@thelamer thelamer deleted the initial branch June 6, 2025 19:24
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants