Skip to content

rebase to selkies#178

Merged
aptalca merged 2 commits into
masterfrom
selkies-test
Jul 26, 2025
Merged

rebase to selkies#178
aptalca merged 2 commits into
masterfrom
selkies-test

Conversation

@aptalca

@aptalca aptalca commented Jul 26, 2025

Copy link
Copy Markdown
Member

No description provided.

@aptalca aptalca requested a review from a team July 26, 2025 15:34
@LinuxServer-CI LinuxServer-CI moved this to PRs Ready For Team Review in Issue & PR Tracker Jul 26, 2025
@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/calibre/v8.7.0-pkg-de0c9665-dev-025aa945e940f7bb66314aa4b15c210688ef012f-pr-178/index.html
https://ci-tests.linuxserver.io/lspipepr/calibre/v8.7.0-pkg-de0c9665-dev-025aa945e940f7bb66314aa4b15c210688ef012f-pr-178/shellcheck-result.xml

Tag Passed
amd64-v8.7.0-pkg-de0c9665-dev-025aa945e940f7bb66314aa4b15c210688ef012f-pr-178
arm64v8-v8.7.0-pkg-de0c9665-dev-025aa945e940f7bb66314aa4b15c210688ef012f-pr-178

@thelamer thelamer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to rebase, but more of an FYI as I went through my testing, when I first implemented audio in the rdesktop containers the read aloud feature was emphasized by a blind user. You might want to look into the possibility of fixing this.
readaloud

@github-project-automation github-project-automation Bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker Jul 26, 2025
@aptalca

aptalca commented Jul 26, 2025

Copy link
Copy Markdown
Member Author

Just tested and it's most likely a perm issue. I looks like it is downloading the data but can't write/transfer it. I just need to figure out where exactly it's trying to write it to.

@aptalca

aptalca commented Jul 26, 2025

Copy link
Copy Markdown
Member Author

Well, it downloaded the onnx file into the config folder. But something else breaks after. The log I get is:

calibre, version 8.5.0
ERROR: Unhandled exception: <b>Exception</b>:Could not download voice data

calibre 8.5  embedded-python: True
Linux-6.12.33+deb12-amd64-x86_64-with-glibc2.39 Linux ('64bit', 'ELF')
('Linux', '6.12.33+deb12-amd64', '#1 SMP PREEMPT_DYNAMIC Debian 6.12.33-1~bpo12+1 (2025-07-09)')
Python 3.11.12
Interface language: None
EXE path: /opt/calibre/bin/calibre-parallel
Successfully initialized third party plugins: Modify ePub (1, 8, 6)
Traceback (most recent call last):
  File "calibre/gui2/viewer/tts.py", line 42, in action
  File "calibre/gui2/viewer/tts.py", line 46, in play
  File "calibre/gui2/tts/manager.py", line 180, in speak_marked_text
  File "calibre/gui2/tts/piper.py", line 321, in say
  File "calibre/gui2/tts/piper.py", line 308, in _wait_for_process_to_start
  File "calibre/gui2/tts/piper.py", line 401, in process
  File "calibre/gui2/tts/piper.py", line 65, in piper_process_metadata
Exception: Could not download voice data

The relevant files are at https://github.com/kovidgoyal/calibre/tree/master/src/calibre/gui2/tts

I'll dig in later

@aptalca

aptalca commented Jul 26, 2025

Copy link
Copy Markdown
Member Author

I got it to work, but no idea why it fails in calibre. I'll report to them.

Basically, it needs to download 2 files and place them into /config/.cache/calibre/piper-voices:

  • https://huggingface.co/rhasspy/piper-voices/resolve/v1.0.0/en/en_US/libritts/high/en_US-libritts-high.onnx
  • https://huggingface.co/rhasspy/piper-voices/resolve/v1.0.0/en/en_US/libritts/high/en_US-libritts-high.onnx.json

It successfully downloads the onnx file, but somehow fails on the json one. Manually downloading the json file made it work:

docker exec -it calibre bash
curl -L https://huggingface.co/rhasspy/piper-voices/resolve/v1.0.0/en/en_US/libritts/high/en_US-libritts-high.onnx.json -o /config/.cache/calibre/piper-voices/en_US-libritts-high.onnx.json
chown abc:abc /config/.cache/calibre/piper-voices/en_US-libritts-high.onnx.json

@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/calibre/v8.7.0-pkg-de0c9665-dev-edff72e1349c1edb1fe4974ebdb3aa3b0649b1f9-pr-178/index.html
https://ci-tests.linuxserver.io/lspipepr/calibre/v8.7.0-pkg-de0c9665-dev-edff72e1349c1edb1fe4974ebdb3aa3b0649b1f9-pr-178/shellcheck-result.xml

Tag Passed
amd64-v8.7.0-pkg-de0c9665-dev-edff72e1349c1edb1fe4974ebdb3aa3b0649b1f9-pr-178
arm64v8-v8.7.0-pkg-de0c9665-dev-edff72e1349c1edb1fe4974ebdb3aa3b0649b1f9-pr-178

@aptalca aptalca merged commit 0bce396 into master Jul 26, 2025
3 checks passed
@aptalca aptalca deleted the selkies-test branch July 26, 2025 19:54
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants