Switch to Github latest release#7
Closed
tinuva wants to merge 6 commits into
Closed
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Author
|
The arm version fails to build, because Jenkins is building 0.20.2 which on github doesnt have a binary for arm64 I am not sure how to get the jenkins server to build 1.0.0 version. However it definitely works locally for me. |
Collaborator
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Still valid as an alternative while pr #6 is not merged |
Author
|
still need a review |
Member
|
Please chime in on #8 if you have feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Switch away from debian package (still outdated at 0.20.2) to the github appimage release.
Benefits of this PR and context:
In short, currently it provides Freecad 1.0 which is much improved over 0.20.2
Updated to always point to the "latest" release by default. However I did test and it is possible to use 0.20.2 as a build arg to build 0.20.2 as an example. The weekly release I think will only work, if they contain an asset for x86_64 or aarch64 which sometimes for me didn't work.
So, unlike PR #6 this does not have the release hardcoded. I used the orcaslicer repo for inspiration.
How Has This Been Tested?
Built the latest version using command:
Then stopped my container, deleted it and used docker compose to load it up. I then browsed to the url to confirm version 1.0.0 is installed and usable.
docker-compse:
In the browser, it looks like this:

Tested the version ARG with:
This also worked in the browser showing the expected version is installed.
Source / References:
Closes #4