You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is a follow up to #380, which didn't work because a failed ci test exits 1, which makes Jenkins skip the rest of the stages altogether.
This PR moves the PR comment script to the post section, which runs even if the build fails.
Tested both success and failure conditions and the comment seems to be added to PR successfully.
The only thing that is not quite ideal is, if ci test fails, a PR comment is added and it references the tags. However, those tags are not pushed to the registries. That may be a bit misleading and confusing. But I think it's still better than not adding a comment at all when the test fails, because that can cause a false positive (much bigger issue) when a successful commit is followed up by a failing commit in the same PR where the user may mistakenly think it succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aptalca
changed the title
github-project-automation
Bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
(Cleaned up and force pushed)
This PR is a follow up to #380, which didn't work because a failed ci test exits 1, which makes Jenkins skip the rest of the stages altogether.
This PR moves the PR comment script to the post section, which runs even if the build fails.
Tested both success and failure conditions and the comment seems to be added to PR successfully.
The only thing that is not quite ideal is, if ci test fails, a PR comment is added and it references the tags. However, those tags are not pushed to the registries. That may be a bit misleading and confusing. But I think it's still better than not adding a comment at all when the test fails, because that can cause a false positive (much bigger issue) when a successful commit is followed up by a failing commit in the same PR where the user may mistakenly think it succeeded.