Fix Jenkinsfile credentials and update templates#128
Closed
ford22 wants to merge 3 commits into
Closed
Conversation
- Update GitHub templates and workflows - Update Jenkinsfile with fixes: * Remove tab character from credentials ID * Add LSIO_FIRST_PARTY check before adding * Remove unnecessary wait command - Update S6 service scripts and permissions - Update readme-vars.yml with proper project_name variable - Sync Dockerfiles with latest baseimage changes Co-authored-by: Jenkins CI <ci@linuxserver.io>"
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Member
|
I appreciate the work that has been put into this, but this is not mergeable in it's current state. Most of the reasons why are listed in the contributing file, which you also updated, so how those key elements flew past you is worrying. |
Author
|
@Roxedus You are right – this PR is not mergeable. I apologize for the noise. I am having technical issues with Git authentication in Codespaces and cannot push fixes. Please close this PR. I will open a new one with only the Thank you for your patience. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Jenkinsfile credentials and update templates
Description:
Fix critical issues in Jenkinsfile (tab character in credentials, duplicate ENV checks, unnecessary wait) and sync all GitHub templates to latest standards.
Key fixes:
ci-tests-s3-secret-access-keycredentialsBenefits:
Prevents CI authentication failures, avoids duplicate ENV vars, improves multi-arch reliability, and keeps templates current.
How Has This Been Tested:
✅ Docker build successful on amd64
✅ Container runs Lidarr 3.1.0.4877 without issues
✅ Web UI accessible on port 8686
✅ All S6 service files have correct permissions
✅ Jenkinsfile syntax valid (no tab characters)
✅ YAML files validated
Tested in GitHub Codespaces with Docker 27.5.1.