Pihole v6 requires the path to be configured. Updated instructions.#807
Open
CBacchus wants to merge 1 commit into
Open
Pihole v6 requires the path to be configured. Updated instructions.#807CBacchus wants to merge 1 commit into
CBacchus wants to merge 1 commit into
Conversation
Pihole v6 requires the path to be configured. Updated instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default subfolder conf still functions correctly after the v6 pihole update given the instance is set up correctly. The previous instructions comment says that a base url is not required. I have updated the instructions to specify that v6 pihole does require a prefix.
Benefits of this PR and context
Having accurate instructions would reduce confusion for users trying to set up this conf.
How Has This Been Tested?
After following my updated instructions myself, I can successfully access my pihole instance through the subfolder.
Source / References
N/A