Skip to content

Commit 08b8c17

Browse files
max-krasnyanskyliparetejas
authored andcommitted
Bump cmake max version (needed for Windows on Snapdragon builds) (ggml-org#19188)
* Bump max cmake version (needed for Windows on Snapdragon builds) * cmake: move max version setting into ggml/CMakeLists
1 parent a06d7b9 commit 08b8c17

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

docs/backend/snapdragon/CMakeUserPresets.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
{
22
"version": 5,
3-
"cmakeMinimumRequired": {
4-
"major": 3,
5-
"minor": 28,
6-
"patch": 0
7-
},
83
"configurePresets": [
94
{
105
"name": "arm64-android-snapdragon",

docs/backend/snapdragon/windows.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ However, additional settings are required for generating and signing HTP Ops lib
128128
> $env:HEXAGON_HTP_CERT="c:\Users\MyUsers\Certs\ggml-htp-v1.pfx"
129129
> $env:WINDOWS_SDK_BIN="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\arm64"
130130
131-
> cmake --preset arm64-windows-snapdragon -B build-wos
131+
> cmake --preset arm64-windows-snapdragon-release -B build-wos
132132
...
133133
> cmake --install build-wos --prefix pkg-snapdragon
134134
```

ggml/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.14) # for add_link_options and implicit target directories.
1+
cmake_minimum_required(VERSION 3.14...3.28) # for add_link_options and implicit target directories.
22
project("ggml" C CXX ASM)
33

44
### GGML Version

0 commit comments

Comments
 (0)